linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Richard Weinberger <richard@nod.at>
To: akpm@linux-foundation.org
Cc: linux-kernel@vger.kernel.org, paul.gortmaker@windriver.com,
	davej@redhat.com, keescook@chromium.org, stable@vger.kernel.org,
	tglx@linutronix.de, gorcunov@openvz.org, ebiederm@xmission.com
Subject: Re: + futex-avoid-kernel-taint-caused-by-get_robust_list.patch added to -mm tree
Date: Fri, 15 Feb 2013 23:44:44 +0100	[thread overview]
Message-ID: <20130215234444.29345fc3@spider.haslach.nod.at> (raw)
In-Reply-To: <20130215222653.B8B115A41F0@corp2gmr1-2.hot.corp.google.com>

Am Fri, 15 Feb 2013 14:26:52 -0800
schrieb akpm@linux-foundation.org:
> ------------------------------------------------------
> From: Paul Gortmaker <paul.gortmaker@windriver.com>
> Subject: futex: avoid kernel taint caused by get_robust_list
> 
> Commit ec0c4274e33c0373e4 ("futex: Mark get_robust_list as
> deprecated") added these two WARN_ONCE calls.
> 
> However, WARN_ONCE taints the kernel, and we shouldn't be allowing any
> user who wanders by to do this.  For example, the system fuzzer
> "trinity" uses the tainted state as a metric for when to stop,
> assuming that it has caused significant wreckage (and indeed that
> tool is what actually led me to this change).
> 
> The ability to deprecate this code has been called into question[1],
> but if that remains to be finalized, then making this change in the
> interim seems to make sense.

Do we really want to remove this system call in 2013?
Note, Documentation/feature-removal-schedule.txt is gone...

CRIU folks, I guess you still need the call?
Or have you found an alternative way to get the robost list?

As stated in [0], I'd simply revert commit ec0c4274 ("futex: Mark
get_robust_list as deprecated")

Thanks,
//richard

[0] http://permalink.gmane.org/gmane.linux.kernel.hardened.devel/506

       reply	other threads:[~2013-02-15 22:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20130215222653.B8B115A41F0@corp2gmr1-2.hot.corp.google.com>
2013-02-15 22:44 ` Richard Weinberger [this message]
2013-02-15 22:58   ` + futex-avoid-kernel-taint-caused-by-get_robust_list.patch added to -mm tree Andrew Morton
2013-02-16  7:02   ` Cyrill Gorcunov
2013-02-18  8:55     ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130215234444.29345fc3@spider.haslach.nod.at \
    --to=richard@nod.at \
    --cc=akpm@linux-foundation.org \
    --cc=davej@redhat.com \
    --cc=ebiederm@xmission.com \
    --cc=gorcunov@openvz.org \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paul.gortmaker@windriver.com \
    --cc=stable@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).