public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Johannes Thumshirn <morbidrsa@gmail.com>
To: Thierry Reding <thierry.reding@avionic-design.de>, morbidrsa@gmail.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pwm: twl: Use to_twl() instead of container_of()
Date: Sat, 16 Feb 2013 20:42:10 +0100	[thread overview]
Message-ID: <20130216194210.GA5679@blackbook> (raw)
In-Reply-To: <20130216185618.GA17744@avionic-0098.mockup.avionic-design.de>

On Sat, Feb 16, 2013 at 07:56:18PM +0100, Thierry Reding wrote:
> On Sat, Feb 16, 2013 at 07:20:51PM +0100, Johannes Thumshirn wrote:
> > In twl6030_pwm_disable() use to_twl() instead of container_of() like in the
> > rest of the driver.
> > 
> > Signed-off-by: Johannes Thumshirn <morbidrsa@gmail.com>
> > ---
> >  drivers/pwm/pwm-twl.c | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> Hi Johannes,
> 
> I see that container_of() is also still used in twl4030_pwm_free() and
> twl6030_pwm_enable(). Would you mind fixing those up as well?
> 
> Thierry

Oh sorry haven't seen them, I'll take care of it.

Johannes

  reply	other threads:[~2013-02-16 19:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-16 18:20 [PATCH] pwm: twl: Use to_twl() instead of container_of() Johannes Thumshirn
2013-02-16 18:56 ` Thierry Reding
2013-02-16 19:42   ` Johannes Thumshirn [this message]
2013-02-16 19:54 ` Johannes Thumshirn
2013-02-16 20:21   ` Thierry Reding
2013-02-17 10:08     ` [PATCH] pwm: twl: Fix typo that broke build Johannes Thumshirn
2013-02-17 10:26       ` Thierry Reding
2013-02-17 15:04         ` Johannes Thumshirn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130216194210.GA5679@blackbook \
    --to=morbidrsa@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=thierry.reding@avionic-design.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox