public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Oleg Nesterov <oleg@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>,
	Linus Torvalds <torvalds@linux-foundation.org>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
	Ingo Molnar <mingo@redhat.com>,
	Mandeep Singh Baines <msb@chromium.org>,
	Neil Horman <nhorman@redhat.com>,
	"Rafael J. Wysocki" <rjw@sisk.pl>,
	Roland McGrath <roland@hack.frob.com>, Tejun Heo <tj@kernel.org>,
	linux-kernel@vger.kernel.org
Subject: [PATCH 0/3] coredump: fix the ancient signal problems
Date: Sun, 17 Feb 2013 20:18:19 +0100	[thread overview]
Message-ID: <20130217191819.GA21778@redhat.com> (raw)

Hello.

These problems are really annoying. I reported and tried to fix
them in 2008 (see http://marc.info/?l=linux-kernel&m=121665710711931)
but nobody was interested.

Since then I had a lot of (to some degree contradictory) bug reports:
we do not want the interrupted coredumps (this is what the current code
tries to achieve but the logic is very wrong), but at the same time some
people blame the coredump because it is not interruptible.

And every time the discussion was confusing, it is not clear what should
we actually do to make everyone happy.

Linus, et al, could you please ack/nack the intent? Of course I will
appreciate if you can review the code, but what I am actually worried
about is the user-visible change: the coredumping becomes killable but
only by the _explicit_ SIGKILL, other fatal signals are "ignored".

The changes were not tested at all, I'll try to recheck everything and
test this tomorrow. I am sending this series right now because I strongly
believe that the recent -mm patches in this area are not right and should
be dropped, and I also disagree with the pending v2.

Mandeep, just in case please note that 1/3 alone should fix the problems
with non-fatal signals and wait_dump_helper(). As for the freezer, afaics
we are almost ready for the (slightly modified) fix proposed in
http://marc.info/?l=linux-kernel&m=136103469831268.

Oleg.

 fs/coredump.c         |   33 +++++++++++++++++++--------------
 include/linux/sched.h |    1 +
 kernel/signal.c       |    6 ++++--
 3 files changed, 24 insertions(+), 16 deletions(-)


             reply	other threads:[~2013-02-17 19:19 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-17 19:18 Oleg Nesterov [this message]
2013-02-17 19:18 ` [PATCH 1/3] coredump: only SIGKILL should interrupt the coredumping task Oleg Nesterov
2013-02-17 19:19 ` [PATCH 2/3] coredump: ensure that SIGKILL always kills the dumping thread Oleg Nesterov
2013-02-17 19:19 ` [PATCH 3/3] coredump: sanitize the setting of signal->group_exit_code Oleg Nesterov
2013-02-17 19:34 ` [PATCH 0/3] coredump: fix the ancient signal problems Linus Torvalds
2013-02-17 19:50   ` Oleg Nesterov
2013-02-17 20:01     ` Oleg Nesterov
2013-02-20  1:29 ` Mandeep Singh Baines
2013-02-20 22:32   ` Oleg Nesterov
2013-02-20 23:14     ` Andrew Morton
2013-02-23 20:21       ` Oleg Nesterov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130217191819.GA21778@redhat.com \
    --to=oleg@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=msb@chromium.org \
    --cc=nhorman@redhat.com \
    --cc=rjw@sisk.pl \
    --cc=roland@hack.frob.com \
    --cc=tj@kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox