From: Greg KH <gregkh@linuxfoundation.org>
To: Robert Berger <git.rber@gmail.com>
Cc: devel@driverdev.osuosl.org, konrad.wilk@oracle.com,
sjenning@linux.vnet.ibm.com, linux-kernel@vger.kernel.org,
xiaoguangrong@linux.vnet.ibm.com, minchan@kernel.org,
joe@perches.com,
Robert Berger <rber.git@ReliableEmbeddedSystems.com>
Subject: Re: [PATCH 2/4] staging/zache BUILD_MODNAME and checkpatch fixes
Date: Mon, 18 Feb 2013 10:51:13 -0800 [thread overview]
Message-ID: <20130218185113.GA24554@kroah.com> (raw)
In-Reply-To: <1361003754-22512-3-git-send-email-rber.git@ReliableEmbeddedSystems.com>
On Sat, Feb 16, 2013 at 10:35:52AM +0200, Robert Berger wrote:
> As per Joe's suggestion:
> "Perhaps it'd be better to use KBUILD_MODNAME all the time
> instead of adding the prefix. Also, to me mixing "ramster: "
> and "zcache: " for the prefixes is odd. Just using zcache
> all the time would be simpler, so remove namestr too."
>
> checkpatch fixes:
> zcache-main.c:1987: WARNING: quoted string split across lines
> zcache-main.c:2002: WARNING: quoted string split across lines
>
> Signed-off-by: Robert Berger <rber.git@ReliableEmbeddedSystems.com>
> ---
> drivers/staging/zcache/zcache-main.c | 137 ++++++++++++++++------------------
> 1 file changed, 65 insertions(+), 72 deletions(-)
This patch fails to apply, care to refresh it, and your 2 other patches
in this series, against the linux-next tree, and resend it so that I can
apply it?
thanks,
greg k-h
next prev parent reply other threads:[~2013-02-18 18:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-16 8:35 [PATCH 0/4] staging/zache KBUILD_MODNAME, checkpatch fixes Robert Berger
2013-02-16 8:35 ` [PATCH 1/4] staging/zache checkpatch ERROR: spaces prohibited around that Robert Berger
2013-02-16 8:35 ` [PATCH 2/4] staging/zache BUILD_MODNAME and checkpatch fixes Robert Berger
2013-02-18 18:51 ` Greg KH [this message]
2013-02-16 8:35 ` [PATCH 3/4] staging/zache KBUILD_MODNAME " Robert Berger
2013-02-16 8:35 ` [PATCH 4/4] staging/zcache KBUILD_MODNAME instead of "ramster: " Robert Berger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130218185113.GA24554@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=git.rber@gmail.com \
--cc=joe@perches.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=minchan@kernel.org \
--cc=rber.git@ReliableEmbeddedSystems.com \
--cc=sjenning@linux.vnet.ibm.com \
--cc=xiaoguangrong@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox