public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Marcin Slusarz <marcin.slusarz@gmail.com>
To: Jiri Slaby <jslaby@suse.cz>
Cc: bskeggs@redhat.com, dri-devel@lists.freedesktop.org,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: WARNING: at drivers/gpu/drm/nouveau/core/core/mm.c:242
Date: Tue, 19 Feb 2013 00:23:35 +0100	[thread overview]
Message-ID: <20130218232335.GA9730@joi.lan> (raw)
In-Reply-To: <5122021F.1060207@suse.cz>

On Mon, Feb 18, 2013 at 11:27:43AM +0100, Jiri Slaby wrote:
> Hi,
> 
> we have a report of WARNING from 3.7.6 in nouveau at
> drivers/gpu/drm/nouveau/core/core/mm.c:242 here:
> https://bugzilla.novell.com/show_bug.cgi?id=802347#c11
> 
> There is an order 4 allocation failure in nouveau_drm_open ->
> nouveau_vm_create, i.e. this one failed:
> vm->pgt  = kcalloc(vm->lpde - vm->fpde + 1, sizeof(*vm->pgt), GFP_KERNEL);
> 
> Then, on the error path in still in nouveau_drm_open, it is followed by
> a call to nouveau_cli_destroy. But that one calls nouveau_vm_ref ->
> nouveau_mm_fini -> nouveau_vm_del -> nouveau_mm_fini which triggers the
> warning.
> 
> Any ideas?

Crash/warning should be fixed by commit cfd376b6bfccf33782a0748a9c70f7f752f8b869
"drm/nouveau/vm: fix memory corruption when pgt allocation fails".

Tomorrow I'll post a patch for page allocation failure.


Marcin


  reply	other threads:[~2013-02-18 23:23 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-18 10:27 WARNING: at drivers/gpu/drm/nouveau/core/core/mm.c:242 Jiri Slaby
2013-02-18 23:23 ` Marcin Slusarz [this message]
2013-02-18 23:43   ` Jiri Slaby
2013-02-19  2:01     ` Page allocation failures (was Re: WARNING: at drivers/gpu/drm/nouveau/core/core/mm.c:242) Peter Hurley
2013-02-19  7:07     ` WARNING: at drivers/gpu/drm/nouveau/core/core/mm.c:242 Marcin Slusarz
2013-02-19 22:32       ` Marcin Slusarz
2013-03-13 10:36         ` Jiri Slaby
2013-06-17  8:45           ` Jiri Slaby
2013-02-20 14:47       ` [stable request] fix for nouveau mem corruption [was: WARNING: at drivers/gpu/drm/nouveau/core/core/mm.c:242] Jiri Slaby
2013-02-20 18:57         ` Marcin Slusarz
2013-02-21 22:06           ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130218232335.GA9730@joi.lan \
    --to=marcin.slusarz@gmail.com \
    --cc=bskeggs@redhat.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jslaby@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox