public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] mips: remove unecessary __linux__ check
@ 2013-02-19  8:12 liguang
  2013-02-19 10:04 ` Ralf Baechle
  0 siblings, 1 reply; 2+ messages in thread
From: liguang @ 2013-02-19  8:12 UTC (permalink / raw)
  To: ralf, linux-mips, linux-kernel; +Cc: liguang

sgidefs.h has strict check for __linux__,
it seems too harsh, as far as I test, 2 cross
compiler for mips will not define it automatically,
and exit build process with error
"#error Use a Linux compiler or give up".
remove it will not hurt, I think.

Signed-off-by: liguang <lig.fnst@cn.fujitsu.com>
---
 arch/mips/include/uapi/asm/sgidefs.h |    8 --------
 1 files changed, 0 insertions(+), 8 deletions(-)

diff --git a/arch/mips/include/uapi/asm/sgidefs.h b/arch/mips/include/uapi/asm/sgidefs.h
index 876442f..5be81f8 100644
--- a/arch/mips/include/uapi/asm/sgidefs.h
+++ b/arch/mips/include/uapi/asm/sgidefs.h
@@ -11,14 +11,6 @@
 #define __ASM_SGIDEFS_H
 
 /*
- * Using a Linux compiler for building Linux seems logic but not to
- * everybody.
- */
-#ifndef __linux__
-#error Use a Linux compiler or give up.
-#endif
-
-/*
  * Definitions for the ISA levels
  *
  * With the introduction of MIPS32 / MIPS64 instruction sets definitions
-- 
1.7.2.5


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] mips: remove unecessary __linux__ check
  2013-02-19  8:12 [PATCH] mips: remove unecessary __linux__ check liguang
@ 2013-02-19 10:04 ` Ralf Baechle
  0 siblings, 0 replies; 2+ messages in thread
From: Ralf Baechle @ 2013-02-19 10:04 UTC (permalink / raw)
  To: liguang; +Cc: linux-mips, linux-kernel

On Tue, Feb 19, 2013 at 04:12:51PM +0800, liguang wrote:

> sgidefs.h has strict check for __linux__,
> it seems too harsh, as far as I test, 2 cross
> compiler for mips will not define it automatically,
> and exit build process with error
> "#error Use a Linux compiler or give up".
> remove it will not hurt, I think.

My mailbox used to get flooded by people who attempted to build a kernel
using something like a mips-elf, mips-sde-elf or even stranger targets.
There are further differences than just the definition of __linux__ so
I eventually applied this check.

  Ralf

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-02-19 10:04 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-02-19  8:12 [PATCH] mips: remove unecessary __linux__ check liguang
2013-02-19 10:04 ` Ralf Baechle

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox