[PATCH 4/4] regulator: palmas: Change the DT node property names to follow the convention

[PATCH 4/4] regulator: palmas: Change the DT node property names to follow the convention

[J Keerthy]

DT node properties should not have "_". Replacing them by "-".

Signed-off-by: J Keerthy <j-keerthy@ti.com>
---
 drivers/regulator/palmas-regulator.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/regulator/palmas-regulator.c b/drivers/regulator/palmas-regulator.c
index 22c6ae2..a7d1d53 100644
--- a/drivers/regulator/palmas-regulator.c
+++ b/drivers/regulator/palmas-regulator.c
@@ -551,17 +551,17 @@ static void palmas_dt_to_pdata(struct device *dev,
 				sizeof(struct palmas_reg_init), GFP_KERNEL);
 
 		ret = of_property_read_u32(palmas_matches[idx].of_node,
-				"ti,warm_reset", &prop);
+				"ti,warm-reset", &prop);
 		if (!ret)
 			pdata->reg_init[idx]->warm_reset = prop;
 
 		ret = of_property_read_u32(palmas_matches[idx].of_node,
-				"ti,roof_floor", &prop);
+				"ti,roof-floor", &prop);
 		if (!ret)
 			pdata->reg_init[idx]->roof_floor = prop;
 
 		ret = of_property_read_u32(palmas_matches[idx].of_node,
-				"ti,mode_sleep", &prop);
+				"ti,mode-sleep", &prop);
 		if (!ret)
 			pdata->reg_init[idx]->mode_sleep = prop;
 
@@ -576,7 +576,7 @@ static void palmas_dt_to_pdata(struct device *dev,
 			pdata->reg_init[idx]->vsel = prop;
 	}
 
-	ret = of_property_read_u32(node, "ti,ldo6_vibrator", &prop);
+	ret = of_property_read_u32(node, "ti,ldo6-vibrator", &prop);
 	if (!ret)
 		pdata->ldo6_vibrator = prop;
 }
-- 
1.7.5.4

Re: [PATCH 4/4] regulator: palmas: Change the DT node property names to follow the convention

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 298 bytes --]

On Mon, Feb 18, 2013 at 10:44:20AM +0530, J Keerthy wrote:
> DT node properties should not have "_". Replacing them by "-".
> 
> Signed-off-by: J Keerthy <j-keerthy@ti.com>

This must need an update to the binding document too, and probably any
DT files that ended up getting merged for it?

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

RE: [PATCH 4/4] regulator: palmas: Change the DT node property names to follow the convention

[J, KEERTHY]

Hi Mark,

> -----Original Message-----
> From: Mark Brown [mailto:broonie@opensource.wolfsonmicro.com]
> Sent: Tuesday, February 19, 2013 6:12 PM
> To: J, KEERTHY
> Cc: lgirdwood@gmail.com; linux-kernel@vger.kernel.org;
> gg@slimlogic.co.uk
> Subject: Re: [PATCH 4/4] regulator: palmas: Change the DT node property
> names to follow the convention
> 
> On Mon, Feb 18, 2013 at 10:44:20AM +0530, J Keerthy wrote:
> > DT node properties should not have "_". Replacing them by "-".
> >
> > Signed-off-by: J Keerthy <j-keerthy@ti.com>
> 
> This must need an update to the binding document too, and probably any
> DT files that ended up getting merged for it?

I have sent a patch with the document update. That is the first patch in
The series.

Regards,
Keerthy

Re: [PATCH 4/4] regulator: palmas: Change the DT node property names to follow the convention

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 584 bytes --]

On Tue, Feb 19, 2013 at 05:10:01PM +0000, J, KEERTHY wrote:

> > This must need an update to the binding document too, and probably any
> > DT files that ended up getting merged for it?

> I have sent a patch with the document update. That is the first patch in
> The series.

You sent the patches as unthreaded mails and didn't CC me on the
first patch so I've not actually seen the documentation.  Incremental
updates like this really ought to be done as part of a single patch
anyway, there's no point in splitting things up and as we've just seen
it can make it harder to review.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

RE: [PATCH 4/4] regulator: palmas: Change the DT node property names to follow the convention

[J, KEERTHY]

Hi Mark,

> -----Original Message-----
> From: Mark Brown [mailto:broonie@opensource.wolfsonmicro.com]
> Sent: Wednesday, February 20, 2013 1:43 AM
> To: J, KEERTHY
> Cc: lgirdwood@gmail.com; linux-kernel@vger.kernel.org;
> gg@slimlogic.co.uk
> Subject: Re: [PATCH 4/4] regulator: palmas: Change the DT node property
> names to follow the convention
> 
> On Tue, Feb 19, 2013 at 05:10:01PM +0000, J, KEERTHY wrote:
> 
> > > This must need an update to the binding document too, and probably
> > > any DT files that ended up getting merged for it?
> 
> > I have sent a patch with the document update. That is the first patch
> > in The series.
> 
> You sent the patches as unthreaded mails and didn't CC me on the first
> patch so I've not actually seen the documentation.  Incremental updates
> like this really ought to be done as part of a single patch anyway,
> there's no point in splitting things up and as we've just seen it can
> make it harder to review.

Extremely sorry about that. I am resending the Patch 1.

Regards,
Keerthy

Re: [PATCH 4/4] regulator: palmas: Change the DT node property names to follow the convention

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 142 bytes --]

On Mon, Feb 18, 2013 at 10:44:20AM +0530, J Keerthy wrote:
> DT node properties should not have "_". Replacing them by "-".

Applied, thanks.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

RE: [PATCH 4/4] regulator: palmas: Change the DT node property names to follow the convention

[J, KEERTHY]

> -----Original Message-----
> From: Mark Brown [mailto:broonie@opensource.wolfsonmicro.com]
> Sent: Friday, March 01, 2013 1:16 PM
> To: J, KEERTHY
> Cc: lgirdwood@gmail.com; linux-kernel@vger.kernel.org;
> gg@slimlogic.co.uk
> Subject: Re: [PATCH 4/4] regulator: palmas: Change the DT node property
> names to follow the convention
> 
> On Mon, Feb 18, 2013 at 10:44:20AM +0530, J Keerthy wrote:
> > DT node properties should not have "_". Replacing them by "-".
> 
> Applied, thanks.

Thanks Mark.