From: Ingo Molnar <mingo@kernel.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
Russell King <linux@arm.linux.org.uk>,
Mike Frysinger <vapier@gentoo.org>,
Michal Simek <monstr@monstr.eu>,
Ralf Baechle <ralf@linux-mips.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mundt <lethal@linux-sh.org>,
"David S. Miller" <davem@davemloft.net>,
Chris Metcalf <cmetcalf@tilera.com>,
Richard Weinberger <richard@nod.at>,
x86@kernel.org
Subject: Re: [patch 1/1] early_printk: Consolidate random copies of identical code
Date: Tue, 19 Feb 2013 14:03:34 +0100 [thread overview]
Message-ID: <20130219130334.GA11137@gmail.com> (raw)
In-Reply-To: <20130219124038.365937990@linutronix.de>
* Thomas Gleixner <tglx@linutronix.de> wrote:
> The early console implementations are the same all over the
> place. Move the print function to kernel/printk and get rid of the
> copies.
>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Cc: Russell King <linux@arm.linux.org.uk>
> Cc: Mike Frysinger <vapier@gentoo.org>
> Cc: Michal Simek <monstr@monstr.eu>
> Cc: Ralf Baechle <ralf@linux-mips.org>
> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Cc: Paul Mundt <lethal@linux-sh.org>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Chris Metcalf <cmetcalf@tilera.com>
> Cc: Richard Weinberger <richard@nod.at>
> Cc: x86@kernel.org
>
> ---
> arch/arm/kernel/early_printk.c | 17 +++--------------
> arch/blackfin/kernel/early_printk.c | 2 --
> arch/microblaze/kernel/early_printk.c | 26 ++++----------------------
> arch/mips/kernel/early_printk.c | 11 +++++------
> arch/powerpc/kernel/udbg.c | 6 ++----
> arch/sh/kernel/sh_bios.c | 2 --
> arch/sparc/kernel/setup_32.c | 1 +
> arch/sparc/kernel/setup_64.c | 8 +++++++-
> arch/tile/kernel/early_printk.c | 27 +++++----------------------
> arch/um/kernel/early_printk.c | 8 +++++---
> arch/unicore32/kernel/early_printk.c | 12 ++++--------
> arch/x86/kernel/early_printk.c | 21 ++-------------------
> include/linux/console.h | 1 +
> include/linux/printk.h | 6 ++++++
> kernel/printk.c | 30 +++++++++++++++++++++++-------
> 15 files changed, 68 insertions(+), 110 deletions(-)
Reviewed-by: Ingo Molnar <mingo@kernel.org>
Thanks,
Ingo
next prev parent reply other threads:[~2013-02-19 13:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-19 12:44 [patch 1/1] early_printk: Consolidate random copies of identical code Thomas Gleixner
2013-02-19 13:03 ` Ingo Molnar [this message]
2013-02-19 18:30 ` Mike Frysinger
2013-02-19 23:20 ` Paul Gortmaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130219130334.GA11137@gmail.com \
--to=mingo@kernel.org \
--cc=benh@kernel.crashing.org \
--cc=cmetcalf@tilera.com \
--cc=davem@davemloft.net \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=monstr@monstr.eu \
--cc=ralf@linux-mips.org \
--cc=richard@nod.at \
--cc=tglx@linutronix.de \
--cc=vapier@gentoo.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox