From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933166Ab3BSP2d (ORCPT ); Tue, 19 Feb 2013 10:28:33 -0500 Received: from moutng.kundenserver.de ([212.227.126.186]:63889 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933036Ab3BSP2a (ORCPT ); Tue, 19 Feb 2013 10:28:30 -0500 From: Arnd Bergmann To: balbi@ti.com Subject: Re: [PATCH v2 0/5] Generic PHY Framework Date: Tue, 19 Feb 2013 15:28:17 +0000 User-Agent: KMail/1.12.2 (Linux/3.8.0-6-generic; KDE/4.3.2; x86_64; ; ) Cc: kishon , rob@landley.net, tony@atomide.com, linux@arm.linux.org.uk, eballetbo@gmail.com, javier@dowhile0.org, gregkh@linuxfoundation.org, akpm@linux-foundation.org, mchehab@redhat.com, cesarb@cesarb.net, davem@davemloft.net, santosh.shilimkar@ti.com, broonie@opensource.wolfsonmicro.com, swarren@nvidia.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-usb@vger.kernel.org, netdev@vger.kernel.org References: <1361253198-7401-1-git-send-email-kishon@ti.com> <201302191434.40495.arnd@arndb.de> <20130219150500.GG4390@arwen.pp.htv.fi> In-Reply-To: <20130219150500.GG4390@arwen.pp.htv.fi> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201302191528.17698.arnd@arndb.de> X-Provags-ID: V02:K0:ZHKBpAaBd3PjMGieP1oXPy+btmP57Wbtccrm5TU83b/ UznycnDzm/jQHgJR/A3VW+kYlhRNB9iIsejgkejWnTd7tj3tM4 cgEFU2lSpMlelX6G1uEcaZra53sKtoF0U5mogJQdTX0dBK2Urc Ij7n947MjUN2GWtsNL1LLOkn7j+LTJTT8vZPFn0G6owrrm61Z1 fG9WeJMuU1TPC7PQzW3CyegYAmro5SDmy+EvvrCmAR/Hw+iUYk X76NiGyk6NtPJv2RSBiEqv5ciNcdAAMJ+HlBgE+Tzqqqd4Z5cv vxzG7utr3BYnqWp68+7adJJv3r7RHl7hAfXJBanIMYbHb8WLfD NtHNmrGEDM1eCpvRN+Xg= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 19 February 2013, Felipe Balbi wrote: > On Tue, Feb 19, 2013 at 02:34:40PM +0000, Arnd Bergmann wrote: > > On Tuesday 19 February 2013, Felipe Balbi wrote: > > > On Tue, Feb 19, 2013 at 12:33:54PM +0000, Arnd Bergmann wrote: > > It's a fine line, but I think a phy is something that resembles a device > > more than an LED does. When I read patch 1, I also noticed and commented > > on the fact that it does use a 'class'. Now, according to Greg, we should > > use 'bus_type' instead of 'class' in new code. I originally disagreed with > > that concept, but he's the boss here and it's good if he has a vision > > how things should be lined out. > > > > In practice, there is little difference between a 'bus_type' and a 'class', > > so just replace any instance of the former with the latter in your head > > when reading the code ;-) > > it's not so simple :-) if we must use bus_type we need to introduce all > the device/driver matching mechanism which isn't necessary with a class. I think the idea is to use a bus_type that has devices but no drivers associated with it, but I might be misremembering things. > > I understand that there is not a real common bus here, and the bus_type > > infrastructure would basically be used as a way to represent each PHY > > in sysfs and provide a way to enumerate and look them up inside of the > > kernel. > > right, but maybe we need another mechanism. If, in the long run we must > use bus_type, then eventually pwm, led, regulators, etc will all be > converted to bus_type. It will look quite weird IMHO. Yes, it would be a bit unusual, I agree. > Greg, can you pitch your suggestion here ? It would be great to hear > your rationale behind dropping class infrastructure, couldn't find > anything through Google and since feature-removal-schedule.txt has been > removed (without adding it to feature-removal-schedule.txt, I must add > :-) I don't know what's the idea behind removing classes. I believe for now, the idea is to not add any new classes, but keep the existing ones for compatibility. 'struct class_device' however was already removed and got turned into 'struct device'. Arnd