From: Andrew Morton <akpm@linux-foundation.org>
To: Peter Jones <pjones@redhat.com>
Cc: Fabio Estevam <festevam@gmail.com>,
sfr@canb.auug.org.au, linux-kernel@vger.kernel.org,
Fabio Estevam <fabio.estevam@freescale.com>,
Matt Fleming <matt.fleming@intel.com>,
Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH] block: partitions: efi: Typecast sizeof(gpt_header)
Date: Wed, 20 Feb 2013 12:59:43 -0800 [thread overview]
Message-ID: <20130220125943.df50cc67.akpm@linux-foundation.org> (raw)
In-Reply-To: <20130220162748.GA32341@fenchurch.internal.datastacks.com>
On Wed, 20 Feb 2013 11:27:48 -0500
Peter Jones <pjones@redhat.com> wrote:
> On Wed, Feb 20, 2013 at 11:52:10AM -0300, Fabio Estevam wrote:
> > From: Fabio Estevam <fabio.estevam@freescale.com>
> >
> > Since commit ef25bb0fa6e2 (block/partitions/efi.c: ensure that the GPT header is
> > at least the size of the structure.) , when building for a 32-bit architecture,
> > such as ARM, the following build warning is seen:
> >
> > block/partitions/efi.c:324:3: warning: format '%lu' expects argument of type 'long unsigned int', but argument 3 has type 'unsigned int' [-Wformat]
>
> Hi Fabio,
>
> I sent and updated version of ef25bb0fa6e2 this morning to fix this
> issue. Thanks for the patch, though. Andrew, if you'd like you can
> just use this instead of replacing my patch with the new one.
You're both wrong ;) Print a size_t with %z:
--- a/block/partitions/efi.c~ensure-that-the-gpt-header-is-at-least-the-size-of-the-structure-fix
+++ a/block/partitions/efi.c
@@ -321,7 +321,7 @@ static int is_gpt_valid(struct parsed_pa
/* Check the GUID Partition Table header size is too small */
if (le32_to_cpu((*gpt)->header_size) < sizeof(gpt_header)) {
- pr_debug("GUID Partition Table Header size is too small: %u < %lu\n",
+ pr_debug("GUID Partition Table Header size is too small: %u < %zu\n",
le32_to_cpu((*gpt)->header_size),
sizeof(gpt_header));
goto fail;
_
prev parent reply other threads:[~2013-02-20 20:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-20 14:52 [PATCH] block: partitions: efi: Typecast sizeof(gpt_header) Fabio Estevam
2013-02-20 16:27 ` Peter Jones
2013-02-20 20:59 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130220125943.df50cc67.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=fabio.estevam@freescale.com \
--cc=festevam@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.fleming@intel.com \
--cc=pjones@redhat.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox