From: Ingo Molnar <mingo@kernel.org>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Mandeep Singh Baines <msb@chromium.org>,
linux-kernel@vger.kernel.org, Oleg Nesterov <oleg@redhat.com>,
Tejun Heo <tj@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@redhat.com>
Subject: Re: [PATCH v3] lockdep: check that no locks held at freeze time
Date: Wed, 20 Feb 2013 14:52:11 +0100 [thread overview]
Message-ID: <20130220135211.GA11816@gmail.com> (raw)
In-Reply-To: <7488660.sdbECaVo1t@vostro.rjw.lan>
* Rafael J. Wysocki <rjw@sisk.pl> wrote:
> On Wednesday, February 20, 2013 11:37:19 AM Ingo Molnar wrote:
> >
> > * Mandeep Singh Baines <msb@chromium.org> wrote:
> >
> > > We shouldn't try_to_freeze if locks are held. Verified that
> > > I get no lockdep warnings after applying this patch and
> > > "vfork: don't freezer_count() for in-kernel users of CLONE_VFORK".
> > >
> > > Changes since v1:
> > > * LKML: <20130215111635.GA26955@gmail.com> Ingo Molnar
> > > * Added a msg string that gets passed in.
> > > * LKML: <20130215154449.GD30829@redhat.com> Oleg Nesterov
> > > * Check PF_NOFREEZE in try_to_freeze().
> > > Changes since v2:
> > > * LKML: <20130216170605.GC4910@redhat.com> Oleg Nesterov
> > > * Avoid unnecessary PF_NOFREEZE check when !CONFIG_LOCKDEP.
> > > * Mandeep Singh Baines
> > > * Generalize an exit specific printk.
> > >
> > > Signed-off-by: Mandeep Singh Baines <msb@chromium.org>
> > > CC: Oleg Nesterov <oleg@redhat.com>
> > > CC: Tejun Heo <tj@kernel.org>
> > > CC: Andrew Morton <akpm@linux-foundation.org>
> > > CC: Rafael J. Wysocki <rjw@sisk.pl>
> > > CC: Ingo Molnar <mingo@redhat.com>
> >
> > Looks good to me now.
> >
> > Acked-by: Ingo Molnar <mingo@kernel.org>
> >
> > Which tree should this go through?
>
> Well, I can take it if that's OK.
Sure, that's fine with me - this is mainly a freezer feature
after all.
Thanks,
Ingo
next prev parent reply other threads:[~2013-02-20 13:52 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-16 9:53 [PATCH 1/5] vfork: don't freezer_count() for in-kernel users of CLONE_VFORK Mandeep Singh Baines
2013-02-16 9:53 ` [PATCH 2/5] lockdep: check that no locks held at freeze time Mandeep Singh Baines
2013-02-16 17:06 ` Oleg Nesterov
2013-02-20 1:57 ` [PATCH v3] " Mandeep Singh Baines
2013-02-20 10:37 ` Ingo Molnar
2013-02-20 12:55 ` Rafael J. Wysocki
2013-02-20 13:52 ` Ingo Molnar [this message]
2013-02-20 22:30 ` Oleg Nesterov
2013-02-20 23:11 ` Mandeep Singh Baines
2013-02-20 23:17 ` [PATCH v4] " Mandeep Singh Baines
2013-02-20 23:24 ` Andrew Morton
2013-02-21 0:17 ` Mandeep Singh Baines
2013-02-21 0:20 ` Andrew Morton
2013-02-21 0:28 ` Mandeep Singh Baines
2013-02-21 0:42 ` Andrew Morton
2013-02-21 3:19 ` Mandeep Singh Baines
2013-02-21 3:17 ` [PATCH v5] " Mandeep Singh Baines
2013-02-21 15:42 ` Rafael J. Wysocki
2013-02-21 16:24 ` Mandeep Singh Baines
2013-02-21 16:51 ` [PATCH v6] " Mandeep Singh Baines
2013-02-21 21:42 ` Andrew Morton
2013-02-21 21:57 ` Mandeep Singh Baines
2013-02-16 9:53 ` [PATCH 3/5] coredump: use a freezable_schedule for the coredump_finish wait Mandeep Singh Baines
2013-02-16 17:17 ` Oleg Nesterov
2013-02-16 9:53 ` [PATCH 4/5] freezer: clear fake signal on exit from __refrigerator Mandeep Singh Baines
2013-02-16 17:06 ` Oleg Nesterov
2013-02-16 17:12 ` Oleg Nesterov
2013-02-20 18:09 ` Mandeep Singh Baines
2013-02-23 19:41 ` Oleg Nesterov
2013-02-23 19:59 ` Oleg Nesterov
2013-02-16 9:53 ` [PATCH 5/5] coredump: ignore non-fatal signals when core dumping to a pipe Mandeep Singh Baines
2013-02-16 17:10 ` Oleg Nesterov
2013-02-16 19:46 ` Oleg Nesterov
2013-02-18 23:55 ` Mandeep Singh Baines
2013-02-19 14:18 ` Oleg Nesterov
2013-02-19 5:19 ` Mandeep Singh Baines
2013-02-19 14:27 ` Oleg Nesterov
2013-02-19 19:33 ` Mandeep Singh Baines
2013-02-19 19:45 ` Oleg Nesterov
2013-02-19 20:20 ` Mandeep Singh Baines
2013-02-20 23:30 ` Mandeep Singh Baines
2013-02-23 19:21 ` Oleg Nesterov
2013-02-16 17:05 ` [PATCH 1/5] vfork: don't freezer_count() for in-kernel users of CLONE_VFORK Oleg Nesterov
2013-02-20 0:07 ` Mandeep Singh Baines
2013-02-20 1:41 ` Mandeep Singh Baines
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130220135211.GA11816@gmail.com \
--to=mingo@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=msb@chromium.org \
--cc=oleg@redhat.com \
--cc=rjw@sisk.pl \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).