* [PATCH] mfd: trivially fix build warning in sta2x11-mfd
@ 2013-02-22 9:39 Alessandro Rubini
2013-02-22 10:25 ` Davide Ciminaghi
2013-04-08 15:29 ` Samuel Ortiz
0 siblings, 2 replies; 3+ messages in thread
From: Alessandro Rubini @ 2013-02-22 9:39 UTC (permalink / raw)
To: linux-kernel; +Cc: Giancarlo Asnaghi, Samuel Ortiz
This driver cannot be a module, so "remove" is never called. The
mishap is mine, and back then there was no warning due to __devexit().
Signed-off-by: Alessandro Rubini <rubini@gnudd.com>
Acked-by: Giancarlo Asnaghi <giancarlo.asnaghi@st.com>
---
drivers/mfd/sta2x11-mfd.c | 11 -----------
1 files changed, 0 insertions(+), 11 deletions(-)
diff --git a/drivers/mfd/sta2x11-mfd.c b/drivers/mfd/sta2x11-mfd.c
index 9bd3316..d70a3430 100644
--- a/drivers/mfd/sta2x11-mfd.c
+++ b/drivers/mfd/sta2x11-mfd.c
@@ -98,17 +98,6 @@ static int sta2x11_mfd_add(struct pci_dev *pdev, gfp_t flags)
return 0;
}
-static int mfd_remove(struct pci_dev *pdev)
-{
- struct sta2x11_mfd *mfd = sta2x11_mfd_find(pdev);
-
- if (!mfd)
- return -ENODEV;
- list_del(&mfd->list);
- kfree(mfd);
- return 0;
-}
-
/* This function is exported and is not expected to fail */
u32 __sta2x11_mfd_mask(struct pci_dev *pdev, u32 reg, u32 mask, u32 val,
enum sta2x11_mfd_plat_dev index)
--
1.7.7.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mfd: trivially fix build warning in sta2x11-mfd
2013-02-22 9:39 [PATCH] mfd: trivially fix build warning in sta2x11-mfd Alessandro Rubini
@ 2013-02-22 10:25 ` Davide Ciminaghi
2013-04-08 15:29 ` Samuel Ortiz
1 sibling, 0 replies; 3+ messages in thread
From: Davide Ciminaghi @ 2013-02-22 10:25 UTC (permalink / raw)
To: Alessandro Rubini; +Cc: linux-kernel, Giancarlo Asnaghi, Samuel Ortiz
On Fri, Feb 22, 2013 at 10:39:59AM +0100, Alessandro Rubini wrote:
> This driver cannot be a module, so "remove" is never called. The
> mishap is mine, and back then there was no warning due to __devexit().
>
> Signed-off-by: Alessandro Rubini <rubini@gnudd.com>
> Acked-by: Giancarlo Asnaghi <giancarlo.asnaghi@st.com>
Acked-by: Davide Ciminaghi <ciminaghi@gnudd.com>
Thanks
Davide
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mfd: trivially fix build warning in sta2x11-mfd
2013-02-22 9:39 [PATCH] mfd: trivially fix build warning in sta2x11-mfd Alessandro Rubini
2013-02-22 10:25 ` Davide Ciminaghi
@ 2013-04-08 15:29 ` Samuel Ortiz
1 sibling, 0 replies; 3+ messages in thread
From: Samuel Ortiz @ 2013-04-08 15:29 UTC (permalink / raw)
To: Alessandro Rubini; +Cc: linux-kernel, Giancarlo Asnaghi
Hi Alessandro,
On Fri, Feb 22, 2013 at 10:39:59AM +0100, Alessandro Rubini wrote:
> This driver cannot be a module, so "remove" is never called. The
> mishap is mine, and back then there was no warning due to __devexit().
>
> Signed-off-by: Alessandro Rubini <rubini@gnudd.com>
> Acked-by: Giancarlo Asnaghi <giancarlo.asnaghi@st.com>
> ---
> drivers/mfd/sta2x11-mfd.c | 11 -----------
> 1 files changed, 0 insertions(+), 11 deletions(-)
Applied, thanks.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-04-08 15:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-02-22 9:39 [PATCH] mfd: trivially fix build warning in sta2x11-mfd Alessandro Rubini
2013-02-22 10:25 ` Davide Ciminaghi
2013-04-08 15:29 ` Samuel Ortiz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox