Re: sched: Fix signedness bug in yield_to()

Marcelo Tosatti
2013-02-22T01:33:06Z

On Thu, Feb 21, 2013 at 09:56:54AM +0100, Ingo Molnar wrote:
>
> * Shuah Khan <shuahkhan@gmail.com> wrote:
>
> > On Tue, Feb 19, 2013 at 7:27 PM, Linux Kernel Mailing List
> > <linux-kernel@vger.kernel.org> wrote:
> > > Gitweb: http://git.kernel.org/linus/;a=commit;h=c3c186403c6abd32e719f005f0af950155a9e54d
> > > Commit: c3c186403c6abd32e719f005f0af950155a9e54d
> > > Parent: e0a79f529d5ba2507486d498b25da40911d95cf6
> > > Author: Dan Carpenter <dan.carpenter@oracle.com>
> > > AuthorDate: Tue Feb 5 14:37:51 2013 +0300
> > > Committer: Ingo Molnar <mingo@kernel.org>
> > > CommitDate: Tue Feb 5 12:59:29 2013 +0100
> > >
> > > sched: Fix signedness bug in yield_to()
> > >
> > > In 7b270f6099 "sched: Bail out of yield_to when source and
> > > target runqueue has one task" we changed this to store -ESRCH so
> > > it needs to be signed.
> >
> > Dan, Ingo,
> >
> > I can't find the 7b270f6099 "sched: Bail out of yield_to when
> > source and target runqueue has one task" in the latest Linus's
> > git. Am I missing something.
> >
> > The current kenel/sched/core.c doesn't have the code from the
> > associated patch https://patchwork.kernel.org/patch/2016651/
>
> As per the lkml discussion that one was supposed to go upstream
> via the KVM tree. Marcelo?

commit c3c186403c6abd32e719f005f0af950155a9e54d
Author: Dan Carpenter <dan.carpenter@oracle.com>
Date: Tue Feb 5 14:37:51 2013 +0300

sched: Fix signedness bug in yield_to()

In 7b270f6099 "sched: Bail out of yield_to when source and
target runqueue has one task" we changed this to store -ESRCH so
it needs to be signed.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: kbuild@01.org
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Mike Galbraith <efault@gmx.de>
Link: http://lkml.kernel.org/r/20130205113751.GA20521@elgon.mountain
Signed-off-by: Ingo Molnar <mingo@kernel.org>