From: Michal Marek <mmarek@suse.cz>
To: Bin Wang <wbin00@gmail.com>
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] scripts/package/Makefile: remove useless KBUILD_OUTPUT test
Date: Fri, 22 Feb 2013 11:20:38 +0100 [thread overview]
Message-ID: <20130222102038.GC12402@pobox.suse.cz> (raw)
In-Reply-To: <1358753285-11812-1-git-send-email-wbin00@gmail.com>
On Mon, Jan 21, 2013 at 03:28:05PM +0800, Bin Wang wrote:
> The test of KBUILD_OUTPUT in "rpm-pkg rpm" target is useless.
> KBUILD_OUTPUT is always empty here.
Right, but the error message is valid, make rpm-pkg does not work with
O=. So I suggest to either fix make O=... rpm-pkg, or fix the test to
compare $(srctree) and $(objtree) instead.
Michal
prev parent reply other threads:[~2013-02-22 10:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-21 7:28 [PATCH 1/1] scripts/package/Makefile: remove useless KBUILD_OUTPUT test Bin Wang
2013-02-22 10:20 ` Michal Marek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130222102038.GC12402@pobox.suse.cz \
--to=mmarek@suse.cz \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wbin00@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox