From: Kumar amit mehta <gmate.amit@gmail.com>
To: Ian Abbott <abbotti@mev.co.uk>
Cc: gregkh@linuxfoundation.org, fmhess@users.sourceforge.net,
hsweeten@visionengravers.com, dan.carpenter@oracle.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH v2] staging: comedi: drivers: usbduxsigma.c: fix DMA buffers on stack
Date: Fri, 22 Feb 2013 06:26:20 -0800 [thread overview]
Message-ID: <20130222142619.GA11141@gmail.com> (raw)
In-Reply-To: <51274244.6080507@mev.co.uk>
On Fri, Feb 22, 2013 at 10:02:44AM +0000, Ian Abbott wrote:
> On 2013-02-22 06:07, Kumar Amit Mehta wrote:
> >This patch fixes an instance of DMA buffer on stack(being passed to
> >usb_control_msg)for the USB-DUXsigma Board driver. Found using smatch.
> >
>
> Looks good here too.
>
> Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
>
> Would you mind doing the same for usbdux.c and usbduxfast.c?
Sure.
As pointed out by Dan, Do you really want the buffer to be of 16 bytes, as we
are using only the first byte and passing the length as '1' in:
usbduxsub_start, usbduxsub_stop, usbduxfastsub_start, usbduxfastsub_stop ?
~Amit
next prev parent reply other threads:[~2013-02-22 14:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-22 6:07 [PATCH v2] staging: comedi: drivers: usbduxsigma.c: fix DMA buffers on stack Kumar Amit Mehta
2013-02-22 6:26 ` Dan Carpenter
2013-02-22 10:02 ` Ian Abbott
2013-02-22 14:26 ` Kumar amit mehta [this message]
2013-02-22 15:36 ` Ian Abbott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130222142619.GA11141@gmail.com \
--to=gmate.amit@gmail.com \
--cc=abbotti@mev.co.uk \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=fmhess@users.sourceforge.net \
--cc=gregkh@linuxfoundation.org \
--cc=hsweeten@visionengravers.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox