From: Jack Morgenstein <jackm@dev.mellanox.co.il>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: Roland Dreier <roland@kernel.org>,
Sean Hefty <sean.hefty@intel.com>,
Hal Rosenstock <hal.rosenstock@gmail.com>,
Bart Van Assche <bvanassche@acm.org>,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH v2] IB/mlx4: silence GCC warning
Date: Sun, 24 Feb 2013 14:34:17 +0200 [thread overview]
Message-ID: <201302241434.17586.jackm@dev.mellanox.co.il> (raw)
In-Reply-To: <1361437377.1341.33.camel@x61.thuisdomein>
On Thursday 21 February 2013 11:02, Paul Bolle wrote:
> diff --git a/drivers/infiniband/hw/mlx4/qp.c b/drivers/infiniband/hw/mlx4/qp.c
> index 19e0637..512fde3 100644
> --- a/drivers/infiniband/hw/mlx4/qp.c
> +++ b/drivers/infiniband/hw/mlx4/qp.c
> @@ -1778,8 +1778,8 @@ static int build_mlx_header(struct mlx4_ib_sqp *sqp, struct ib_send_wr *wr,
> }
>
> vlan = rdma_get_vlan_id(&sgid);
> - is_vlan = vlan < 0x1000;
> }
Nice try!
However, this approach does add the line below to processing for an IB port (ETH/RoCE port stays same, more or less).
Processing time is therefore increased (at least on the IB side) relative to just living with the warning.
Roland?
> + is_vlan = vlan < 0x1000; <=== Code line added to IB-side processing.
> ib_ud_header_init(send_size, !is_eth, is_eth, is_vlan, is_grh, 0, &sqp->ud_header);
>
> if (!is_eth) {
-Jack
next prev parent reply other threads:[~2013-02-24 12:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-28 12:48 [PATCH] IB/lmx4: silence GCC warning Paul Bolle
2012-10-10 7:23 ` Jack Morgenstein
2012-10-29 9:50 ` Paul Bolle
2013-02-13 13:50 ` Bart Van Assche
2013-02-21 9:02 ` [PATCH v2] IB/mlx4: " Paul Bolle
2013-02-24 12:34 ` Jack Morgenstein [this message]
2013-02-25 16:54 ` Roland Dreier
2013-02-25 17:23 ` Roland Dreier
2013-02-26 7:57 ` Jack Morgenstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201302241434.17586.jackm@dev.mellanox.co.il \
--to=jackm@dev.mellanox.co.il \
--cc=bvanassche@acm.org \
--cc=hal.rosenstock@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=pebolle@tiscali.nl \
--cc=roland@kernel.org \
--cc=sean.hefty@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).