Re: [PATCH] acerhdf: Fix fan activation with new thermal governor

Zhang Rui
2013-02-25T02:58:27Z

On Sun, 2013-02-24 at 12:28 +0100, Borislav Petkov wrote:
> On Sat, Feb 23, 2013 at 08:20:10PM +0100, Borislav Petkov wrote:
> > From: Borislav Petkov <bp@suse.de>
> >
> > The new step_wise thermal governor wasn't able to handle the one-trip
> > point design of acerhdf where we want to turn off the fan if we go under
> > the 'fanoff' temperature and to turn it on only after exceeding the
> > 'fanon' temperature.
> >
> > Do that by looking at the current fan state and return the temperature
> > accordingly.
> >
> > Suggested-by: Zhang Rui <rui.zhang@intel.com>
> > Cc: Peter Feuerer <peter@piie.net>
> > Cc: Andreas Mohr <andi@lisas.de>
> > Cc: Alexander Lam <azl@andrew.cmu.edu>
> > Signed-off-by: Borislav Petkov <bp@suse.de>
>
> Ok, ignore this one for now - the suspend/resume path doesn't pan out
> somehow, need to do some more handholding here.
>
hmm,
this reminds me that we should do a thermal_zone_device_update() for
each registered thermal zone when resuming from system suspend.

thanks,
rui