Re: [PATCH] acerhdf: Fix fan activation with new thermal governor

Peter Feuerer
2013-02-24T11:43:56Z

Hi Boris,

thanks for your best wishes in the last mail, I'm feeling little better now.

Borislav Petkov writes:

> On Sat, Feb 23, 2013 at 08:20:10PM +0100, Borislav Petkov wrote:
>> From: Borislav Petkov <bp@suse.de>
>>
>> The new step_wise thermal governor wasn't able to handle the one-trip
>> point design of acerhdf where we want to turn off the fan if we go under
>> the 'fanoff' temperature and to turn it on only after exceeding the
>> 'fanon' temperature.
>>
>> Do that by looking at the current fan state and return the temperature
>> accordingly.
>>
>> Suggested-by: Zhang Rui <rui.zhang@intel.com>
>> Cc: Peter Feuerer <peter@piie.net>
>> Cc: Andreas Mohr <andi@lisas.de>
>> Cc: Alexander Lam <azl@andrew.cmu.edu>
>> Signed-off-by: Borislav Petkov <bp@suse.de>
>
> Ok, ignore this one for now - the suspend/resume path doesn't pan out
> somehow, need to do some more handholding here.

Please test my last patch with the 4 trip points ;) - even if you don't
really like it, it is working great! - And to be honest, I still prefer this
solution!

Anyhow, did you test what Rui asked us to test?

--
kind regards,
--peter;