From: Andrew Morton <akpm@linux-foundation.org>
To: Artem Savkov <artem.savkov@gmail.com>
Cc: ibm-acpi-devel@lists.sourceforge.net,
platform-driver-x86@vger.kernel.org, ibm-acpi@hmh.eng.br,
matthew.garrett@nebula.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] thinkpad_acpi: moved hotkey_thread_mutex lock after set_freezable()
Date: Mon, 25 Feb 2013 15:54:45 -0800 [thread overview]
Message-ID: <20130225155445.d3eef1ad.akpm@linux-foundation.org> (raw)
In-Reply-To: <1361697722-4575-1-git-send-email-artem.savkov@gmail.com>
On Sun, 24 Feb 2013 13:22:02 +0400
Artem Savkov <artem.savkov@gmail.com> wrote:
> set_freezable() checks freezing during which no locks should be held.
> hotkey_thread_mutex lock should be moved closer to where it is actually needed.
>
Thanks.
When fixing a bug, we always like to see a full description of that bug
so we can better work out which kernel versions need the fix.
Did you actually hit a lockup because of this? Or was it just from
code inspection? Or ... ?
next prev parent reply other threads:[~2013-02-25 23:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-24 9:22 [PATCH] thinkpad_acpi: moved hotkey_thread_mutex lock after set_freezable() Artem Savkov
2013-02-25 23:54 ` Andrew Morton [this message]
2013-02-26 5:47 ` Artem Savkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130225155445.d3eef1ad.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=artem.savkov@gmail.com \
--cc=ibm-acpi-devel@lists.sourceforge.net \
--cc=ibm-acpi@hmh.eng.br \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.garrett@nebula.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox