From: Oleg Nesterov <oleg@redhat.com>
To: David Howells <dhowells@redhat.com>
Cc: Lucas De Marchi <lucas.demarchi@profusion.mobi>,
linux-kernel@vger.kernel.org,
James Morris <james.l.morris@oracle.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] usermodehelper: Fix -ENOMEM return logic
Date: Mon, 25 Feb 2013 17:51:47 +0100 [thread overview]
Message-ID: <20130225165147.GA1024@redhat.com> (raw)
In-Reply-To: <10238.1361804714@warthog.procyon.org.uk>
On 02/25, David Howells wrote:
>
> Lucas De Marchi <lucas.demarchi@profusion.mobi> wrote:
>
> > This patch fixes both call_usermodehelper_fns() to never call the
> > cleanup function in case retval == -ENOMEM and also the callers to
> > actually check the return value of this function.
>
> I suspect it's probably better to always call the cleanup function from
> call_usermodehelper_fns() rather than have the cleanup done by the caller in
> some circumstances and not others - would it make sense to change the cleanup
> function to take the pointer to the caller data rather than to take the
> subprocess_info struct?
I this this will comlicate the logic even more, the "caller data"
has to be kmalloced/kfreed as well.
Btw. __orderly_poweroff() doesn't need any tricks, afaics. I'll send
a simple cleanup in a minute.
Oleg.
next prev parent reply other threads:[~2013-02-25 16:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-25 14:25 [PATCH] usermodehelper: Fix -ENOMEM return logic Lucas De Marchi
2013-02-25 15:05 ` David Howells
2013-02-25 16:51 ` Oleg Nesterov [this message]
2013-02-25 16:06 ` Oleg Nesterov
2013-02-25 17:38 ` Lucas De Marchi
2013-02-25 18:08 ` Oleg Nesterov
2013-03-07 2:05 ` Lucas De Marchi
2013-03-07 19:37 ` Oleg Nesterov
2013-03-07 19:47 ` Lucas De Marchi
2013-03-07 20:07 ` Oleg Nesterov
2013-03-07 21:35 ` Lucas De Marchi
2013-02-25 17:10 ` [PATCH 0/1] usermodehelper: cleanup/fix __orderly_poweroff() && argv_free() Oleg Nesterov
2013-02-25 17:11 ` [PATCH 1/1] " Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130225165147.GA1024@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=james.l.morris@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lucas.demarchi@profusion.mobi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox