public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Oleg Nesterov <oleg@redhat.com>
To: Lucas De Marchi <lucas.demarchi@profusion.mobi>
Cc: linux-kernel@vger.kernel.org, David Howells <dhowells@redhat.com>,
	James Morris <james.l.morris@oracle.com>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: [PATCH 0/1] usermodehelper: cleanup/fix __orderly_poweroff() && argv_free()
Date: Mon, 25 Feb 2013 18:10:14 +0100	[thread overview]
Message-ID: <20130225171014.GB1024@redhat.com> (raw)
In-Reply-To: <1361802350-9299-1-git-send-email-lucas.demarchi@profusion.mobi>

On 02/25, Lucas De Marchi wrote:
>
> it was risking running the cleanup twice (like
> kernel/sys.c:orderly_poweroff()) and if not, a leak could happen.

As for kernel/sys.c:orderly_poweroff(), it simply doesn't need
argv_cleanup() and -ENOMEM check, see 1/1.

Oleg.


  parent reply	other threads:[~2013-02-25 17:11 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-25 14:25 [PATCH] usermodehelper: Fix -ENOMEM return logic Lucas De Marchi
2013-02-25 15:05 ` David Howells
2013-02-25 16:51   ` Oleg Nesterov
2013-02-25 16:06 ` Oleg Nesterov
2013-02-25 17:38   ` Lucas De Marchi
2013-02-25 18:08     ` Oleg Nesterov
2013-03-07  2:05       ` Lucas De Marchi
2013-03-07 19:37         ` Oleg Nesterov
2013-03-07 19:47           ` Lucas De Marchi
2013-03-07 20:07             ` Oleg Nesterov
2013-03-07 21:35               ` Lucas De Marchi
2013-02-25 17:10 ` Oleg Nesterov [this message]
2013-02-25 17:11   ` [PATCH 1/1] usermodehelper: cleanup/fix __orderly_poweroff() && argv_free() Oleg Nesterov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130225171014.GB1024@redhat.com \
    --to=oleg@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=dhowells@redhat.com \
    --cc=james.l.morris@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lucas.demarchi@profusion.mobi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox