From: "'Tejun Heo'" <tj@kernel.org>
To: Jingoo Han <jg1.han@samsung.com>
Cc: "'Andrew Morton'" <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, "'Greg KH'" <greg@kroah.com>,
"'Alessandro Zummo'" <a.zummo@towertech.it>,
rtc-linux@googlegroups.com
Subject: Re: [PATCH V2] rtc: add devm_rtc_device_{register,unregister}()
Date: Mon, 25 Feb 2013 17:30:00 -0800 [thread overview]
Message-ID: <20130226013000.GG2679@htj.dyndns.org> (raw)
In-Reply-To: <20130226012317.GF2679@htj.dyndns.org>
On Mon, Feb 25, 2013 at 05:23:17PM -0800, 'Tejun Heo' wrote:
> again, why do we need the WARN_ON() at all given that other
> devm_*_match() don't do that and the only way to get NULL there would
> be bug in devm_rtc*() code itself rather than its users?
Ughh... I see that you probably copied the chunk from clk / regulator
implementation. Let's please not copy those. Input validation via
WARN_ON()s is nice when the interface is taking input from outside or
the code in question is complex / fragile. Here, the code involved is
like 20 lines and self-contained.
Thanks.
--
tejun
next prev parent reply other threads:[~2013-02-26 1:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-26 1:21 [PATCH V2] rtc: add devm_rtc_device_{register,unregister}() Jingoo Han
2013-02-26 1:23 ` 'Tejun Heo'
2013-02-26 1:30 ` 'Tejun Heo' [this message]
2013-02-26 1:42 ` Jingoo Han
2013-02-26 22:33 ` Dmitry Torokhov
2013-02-27 2:12 ` Jingoo Han
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130226013000.GG2679@htj.dyndns.org \
--to=tj@kernel.org \
--cc=a.zummo@towertech.it \
--cc=akpm@linux-foundation.org \
--cc=greg@kroah.com \
--cc=jg1.han@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox