Re: [ 019/150] serial_core: Fix type definition for PORT_BRCM_TRUMANAGE.

Ben Hutchings
2013-02-28T00:06:12Z

[-- Attachment #1: Type: text/plain, Size: 1432 bytes --]

On Tue, 2013-02-26 at 15:54 -0800, Greg Kroah-Hartman wrote:
> 3.8-stable review patch. If anyone has any objections, please let me know.
>
> ------------------
>
> From: Michael Chan <mchan@broadcom.com>
>
> commit 85f024401bf80746ae08b7fd5809a9b16accf0b1 upstream.
>
> It was mistakenly defined to be 24 instead of the next higher number 25.
>
> Reported-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>
> Cc: Stephen Hurd <shurd@broadcom.com>
> Signed-off-by: Michael Chan <mchan@broadcom.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
> ---
> include/uapi/linux/serial_core.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/include/uapi/linux/serial_core.h
> +++ b/include/uapi/linux/serial_core.h
> @@ -50,7 +50,7 @@
> #define PORT_LPC3220 22 /* NXP LPC32xx SoC "Standard" UART */
> #define PORT_8250_CIR 23 /* CIR infrared port, has its own driver */
> #define PORT_XR17V35X 24 /* Exar XR17V35x UARTs */
> -#define PORT_BRCM_TRUMANAGE 24
> +#define PORT_BRCM_TRUMANAGE 25
> #define PORT_MAX_8250 25 /* max port ID */
>
> /*

Hang on, this is a uapi header - are these numbers actually used by
userland or are they really internal to the 8250 drivers?

Ben.

--
Ben Hutchings
Kids! Bringing about Armageddon can be dangerous. Do not attempt it in
your own home. - Terry Pratchett and Neil Gaiman, `Good Omens'

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]