From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934142Ab3B0BRb (ORCPT ); Tue, 26 Feb 2013 20:17:31 -0500 Received: from ozlabs.org ([203.10.76.45]:60193 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933593Ab3B0BR3 (ORCPT ); Tue, 26 Feb 2013 20:17:29 -0500 Date: Wed, 27 Feb 2013 12:17:25 +1100 From: Michael Ellerman To: Sukadev Bhattiprolu Cc: Peter Zijlstra , Paul Mackerras , Ingo Molnar , Andi Kleen , robert.richter@amd.com, Anton Blanchard , linux-kernel@vger.kernel.org, Stephane Eranian , linuxppc-dev@ozlabs.org, Arnaldo Carvalho de Melo , Jiri Olsa , benh@kernel.crashing.org Subject: Re: [PATCH 5/6][v4]: perf: Create a sysfs entry for Power event format Message-ID: <20130227011725.GA5819@concordia> References: <20130123062201.GA13720@us.ibm.com> <20130123062613.GF13720@us.ibm.com> <20130226052646.GB21553@concordia> <20130226200343.GA21543@us.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130226200343.GA21543@us.ibm.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 26, 2013 at 12:03:43PM -0800, Sukadev Bhattiprolu wrote: > Michael Ellerman [michael@ellerman.id.au] wrote: > | On Tue, Jan 22, 2013 at 10:26:13PM -0800, Sukadev Bhattiprolu wrote: > | > > | > [PATCH 5/6][v4]: perf: Create a sysfs entry for Power event format > | > > | > Create a sysfs entry, '/sys/bus/event_source/devices/cpu/format/event' > | > which describes the format of a POWER cpu. > | > | Did this patch go upstream? I don't see it. > > Hmm, patches 1..4,6 are in linux-tip and Arnaldo's trees but patch 5 is > in neither. I suspect Arnaldo was either waiting for an ACK from Ben, or was expecting Ben to take it? > | > The format of the event is the same for all POWER cpus at least in > | > (Power6, Power7), so bulk of this change is common in the code common > | > to POWER cpus. > | > | No. The event format is different on most POWER cpus, in particular it > | is different on Power6 and Power7, and will be different again on > | Power8. > > Sigh. The port of this patchset to Power6 has not started yet. It should hardly require a port, it's about five lines. But it doesn't matter for now. > But this patchset does work on Power7 correct ? Yes, and without it the rest of the series is essentially useless. So I guess it's better than nothing and we should get it in, we can fix it up later to work across different chips. Ben can you grab it, it's all arch/powerpc. cheers