Re: [PATCH 3/6] powerpc/fsl_pci: Added defines for the FSL PCI controller BRR1 register.

Kumar Gala
2013-02-28T15:46:52Z

On Feb 27, 2013, at 5:33 AM, Joerg Roedel wrote:

> On Mon, Feb 18, 2013 at 06:22:16PM +0530, Varun Sethi wrote:
>> Macros for checking FSL PCI controller version.
>>
>> Signed-off-by: Varun Sethi <Varun.Sethi@freescale.com>
>> ---
>> arch/powerpc/include/asm/pci-bridge.h | 4 ++++
>> 1 files changed, 4 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/powerpc/include/asm/pci-bridge.h b/arch/powerpc/include/asm/pci-bridge.h
>> index 025a130..c12ed78 100644
>> --- a/arch/powerpc/include/asm/pci-bridge.h
>> +++ b/arch/powerpc/include/asm/pci-bridge.h
>> @@ -14,6 +14,10 @@
>>
>> struct device_node;
>>
>> +/* FSL PCI controller BRR1 register */
>> +#define PCI_FSL_BRR1 0xbf8
>> +#define PCI_FSL_BRR1_VER 0xffff
>> +
>
>
> Please merge this patch with the one where you actually make use of
> these defines for the first time.
>
>
> Joerg

This also seems an odd place for these defines.

- k