From: Markus Trippelsdorf <markus@trippelsdorf.de>
To: Namhyung Kim <namhyung@kernel.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [perf patch] perf doesn't delete /tmp/perf-vdso.so.* file on exit
Date: Wed, 27 Feb 2013 14:03:16 +0100 [thread overview]
Message-ID: <20130227130316.GB225@x4> (raw)
In-Reply-To: <loom.20130221T191341-303@post.gmane.org>
On 2013.02.21 at 18:19 +0000, Namhyung Kim wrote:
> Markus Trippelsdorf <markus <at> trippelsdorf.de> writes:
> >
> > perf top doesn't unlink /tmp/perf-vdso.so.* on exit.
> > Fix this by calling vdso__exit() before exit(0).
>
> > @@ -602,6 +603,7 @@ static void *display_thread_tui(void *arg)
> > &top->session->header.env);
> >
> > exit_browser(0);
> > + vdso__exit();
> > exit(0);
> > return NULL;
> > }
>
> I don't think it's enough - it doesn't cover all exit paths.
> I'd suggest making it to use atexit/on_exit().
The issue is fixed by commit 11859e821761.
--
Markus
next prev parent reply other threads:[~2013-02-27 13:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-21 9:45 [perf bugreport] perf doesn't delete /tmp/perf-vdso.so.* file on exit Markus Trippelsdorf
2013-02-21 10:27 ` [perf patch] " Markus Trippelsdorf
2013-02-21 18:19 ` Namhyung Kim
2013-02-27 13:03 ` Markus Trippelsdorf [this message]
2013-02-27 21:12 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130227130316.GB225@x4 \
--to=markus@trippelsdorf.de \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox