[PATCH] TTY: disable debugging warning

[PATCH] TTY: disable debugging warning

[Jiri Slaby]

We added a warning to flush_to_ldisc to report cases when it is called
with a NULL tty. It was for debugging purposes and it lead to a
patchset from Peter Hurley. The patchset however did not make it to
3.9, so disable the warning now to not disturb people.

We can re-add it when the series is in and we are hunting for another
bugs.

Signed-off-by: Jiri Slaby <jslaby@suse.cz>
---
 drivers/tty/tty_buffer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/tty_buffer.c b/drivers/tty/tty_buffer.c
index bb11993..578aa75 100644
--- a/drivers/tty/tty_buffer.c
+++ b/drivers/tty/tty_buffer.c
@@ -425,7 +425,7 @@ static void flush_to_ldisc(struct work_struct *work)
 	struct tty_ldisc *disc;
 
 	tty = port->itty;
-	if (WARN_RATELIMIT(tty == NULL, "tty is NULL\n"))
+	if (tty == NULL)
 		return;
 
 	disc = tty_ldisc_ref(tty);
-- 
1.8.1.4

Re: [PATCH] TTY: disable debugging warning

[Greg KH]

On Wed, Feb 27, 2013 at 10:30:24PM +0100, Jiri Slaby wrote:
> We added a warning to flush_to_ldisc to report cases when it is called
> with a NULL tty. It was for debugging purposes and it lead to a
> patchset from Peter Hurley. The patchset however did not make it to
> 3.9, so disable the warning now to not disturb people.
> 
> We can re-add it when the series is in and we are hunting for another
> bugs.
> 
> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
> ---
>  drivers/tty/tty_buffer.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Thanks, I'll queue this up for 3.9-final, but does it also need to go
into 3.8?

thanks,

greg k-h

Re: [PATCH] TTY: disable debugging warning

[Jiri Slaby]

On 02/27/2013 10:42 PM, Greg KH wrote:
> On Wed, Feb 27, 2013 at 10:30:24PM +0100, Jiri Slaby wrote:
>> We added a warning to flush_to_ldisc to report cases when it is called
>> with a NULL tty. It was for debugging purposes and it lead to a
>> patchset from Peter Hurley. The patchset however did not make it to
>> 3.9, so disable the warning now to not disturb people.
>>
>> We can re-add it when the series is in and we are hunting for another
>> bugs.
>>
>> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
>> ---
>>  drivers/tty/tty_buffer.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Thanks, I'll queue this up for 3.9-final, but does it also need to go
> into 3.8?

That's a question... In 3.8 it happened too, but very seldomly. Read:
only triggerable by trinity fuzz tester after hours of fuzzing. But
yeah, let's disable it there too so that people won't complain.

thanks,
-- 
js
suse labs

Re: [PATCH] TTY: disable debugging warning

[Greg KH]

On Wed, Feb 27, 2013 at 10:48:13PM +0100, Jiri Slaby wrote:
> On 02/27/2013 10:42 PM, Greg KH wrote:
> > On Wed, Feb 27, 2013 at 10:30:24PM +0100, Jiri Slaby wrote:
> >> We added a warning to flush_to_ldisc to report cases when it is called
> >> with a NULL tty. It was for debugging purposes and it lead to a
> >> patchset from Peter Hurley. The patchset however did not make it to
> >> 3.9, so disable the warning now to not disturb people.
> >>
> >> We can re-add it when the series is in and we are hunting for another
> >> bugs.
> >>
> >> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
> >> ---
> >>  drivers/tty/tty_buffer.c | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > Thanks, I'll queue this up for 3.9-final, but does it also need to go
> > into 3.8?
> 
> That's a question... In 3.8 it happened too, but very seldomly. Read:
> only triggerable by trinity fuzz tester after hours of fuzzing. But
> yeah, let's disable it there too so that people won't complain.

Ok, I'll queue it up for the stable release then, thanks.

greg k-h