From: Anton Vorontsov <anton@enomsg.org>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: linux-kernel@vger.kernel.org, David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH] power: make goldfish option have a dependency on goldfish
Date: Wed, 27 Feb 2013 15:18:26 -0800 [thread overview]
Message-ID: <20130227231826.GA30154@lizard.fhda.edu> (raw)
In-Reply-To: <1361989666-1922-1-git-send-email-paul.gortmaker@windriver.com>
Hello Paul,
On Wed, Feb 27, 2013 at 01:27:46PM -0500, Paul Gortmaker wrote:
> Nearly all the other goldfish peripherals (mtd, keyboard, etc)
> have a dependency on the main platform's GOLDFISH Kconfig item,
> but this one got skipped, so add it.
>
> Cc: Anton Vorontsov <cbou@mail.ru>
> Cc: David Woodhouse <dwmw2@infradead.org>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> ---
Our policy, IIRC, has been quite the opposite: we try to put as little
dependencies as possible, letting drivers build on all different kinds of
configs/arches/machines. Why? It helps us keep the code in a good shape.
So, unless there are any unresolable build issues with the driver, I
believe we should keep it as is.
Thanks,
Anton
> drivers/power/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/power/Kconfig b/drivers/power/Kconfig
> index 9e00c38..d314528 100644
> --- a/drivers/power/Kconfig
> +++ b/drivers/power/Kconfig
> @@ -348,7 +348,7 @@ config AB8500_BM
>
> config BATTERY_GOLDFISH
> tristate "Goldfish battery driver"
> - depends on GENERIC_HARDIRQS
> + depends on GENERIC_HARDIRQS && GOLDFISH
> help
> Say Y to enable support for the battery and AC power in the
> Goldfish emulator.
> --
> 1.8.1.2
next prev parent reply other threads:[~2013-02-27 23:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-27 18:27 [PATCH] power: make goldfish option have a dependency on goldfish Paul Gortmaker
2013-02-27 23:18 ` Anton Vorontsov [this message]
2013-02-28 0:48 ` Paul Gortmaker
2013-02-28 1:35 ` Anton Vorontsov
2013-02-28 2:17 ` Paul Gortmaker
2013-02-28 2:59 ` Anton Vorontsov
2013-02-28 6:42 ` Geert Uytterhoeven
2013-03-08 16:38 ` Paul Gortmaker
2013-03-09 1:18 ` Anton Vorontsov
2013-03-09 15:49 ` Paul Gortmaker
2013-03-09 16:52 ` Gene Heskett
2013-03-09 21:59 ` Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130227231826.GA30154@lizard.fhda.edu \
--to=anton@enomsg.org \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox