From: Robin Holt <holt@sgi.com>
To: hpa@sgi.com, Yinghai Lu <yinghai@kernel.org>
Cc: linux-kernel@vger.kernel.org
Subject: Revert commit 5dcd14ecd4 - breaks EFI boot with SLES11 elilo.efi
Date: Thu, 28 Feb 2013 14:52:06 -0600 [thread overview]
Message-ID: <20130228205206.GC3438@sgi.com> (raw)
If I revert that commit (5dcd14ecd4), It completes boot fine. With that
commit applied, by ACPI tables (as well as much else) seems to be
completely messed up. The ACPI XSDT table is removed, all the SRAT
is gone. Much of the remaining ACPI table is messed up. Some of the
EFI memory map is whacked.
If I change the following, things work:
diff --git a/arch/x86/include/asm/bootparam_utils.h b/arch/x86/include/asm/bootparam_utils.h
index 5b5e9cb..85337ab 100644
--- a/arch/x86/include/asm/bootparam_utils.h
+++ b/arch/x86/include/asm/bootparam_utils.h
@@ -19,9 +19,11 @@ static void sanitize_boot_params(struct boot_params *boot_params)
{
if (boot_params->sentinel) {
/*fields in boot_params are not valid, clear them */
+#if 0
memset(&boot_params->olpc_ofw_header, 0,
(char *)&boot_params->alt_mem_k -
(char *)&boot_params->olpc_ofw_header);
+#endif
memset(&boot_params->kbd_status, 0,
(char *)&boot_params->hdr -
(char *)&boot_params->kbd_status);
Thanks,
Robin
next reply other threads:[~2013-02-28 20:52 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-28 20:52 Robin Holt [this message]
2013-02-28 21:05 ` Revert commit 5dcd14ecd4 - breaks EFI boot with SLES11 elilo.efi H. Peter Anvin
2013-02-28 21:09 ` Robin Holt
2013-02-28 21:12 ` H. Peter Anvin
2013-02-28 23:02 ` Yinghai Lu
2013-02-28 23:09 ` H. Peter Anvin
2013-03-05 8:15 ` Robin Holt
2013-03-05 15:22 ` H. Peter Anvin
2013-03-05 19:12 ` Yinghai Lu
2013-03-05 19:52 ` Robin Holt
2013-03-05 20:14 ` Yinghai Lu
2013-03-05 20:22 ` Robin Holt
2013-03-06 16:53 ` Josh Boyer
2013-03-06 17:26 ` H. Peter Anvin
2013-03-06 17:36 ` Josh Boyer
2013-03-06 17:37 ` H. Peter Anvin
2013-03-06 20:40 ` Josh Boyer
2013-03-06 20:43 ` H. Peter Anvin
2013-03-07 4:53 ` [tip:x86/urgent] x86: Don' t clear efi_info even if the sentinel hits tip-bot for Josh Boyer
2013-03-06 18:00 ` [PATCH] Be explicit about what the x86 0x020c boot parameter version requires Peter Jones
2013-03-07 4:31 ` H. Peter Anvin
2013-03-07 8:39 ` Matt Fleming
2013-03-07 4:54 ` [tip:x86/urgent] x86, doc: Be explicit about what the x86 struct boot_params requires tip-bot for Peter Jones
2013-03-06 16:55 ` Revert commit 5dcd14ecd4 - breaks EFI boot with SLES11 elilo.efi Peter Jones
2013-03-06 17:14 ` H. Peter Anvin
2013-03-06 17:32 ` Peter Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130228205206.GC3438@sgi.com \
--to=holt@sgi.com \
--cc=hpa@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox