* [PATCH] regulator: tps6586x: Use dev_err rather than dev_warn for error message
@ 2013-02-20 2:23 Axel Lin
2013-02-20 7:13 ` Stephen Warren
2013-03-01 7:37 ` Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: Axel Lin @ 2013-02-20 2:23 UTC (permalink / raw)
To: Mark Brown
Cc: Stephen Warren, Mike Rapoport, Laxman Dewangan, Liam Girdwood,
linux-kernel
tps6586x_regulator_set_slew_rate() returns -EINVAL when having slew rate
settings for other than SM0/1, thus use dev_err rather than dev_warn.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/regulator/tps6586x-regulator.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/regulator/tps6586x-regulator.c b/drivers/regulator/tps6586x-regulator.c
index e68382d..94a681e 100644
--- a/drivers/regulator/tps6586x-regulator.c
+++ b/drivers/regulator/tps6586x-regulator.c
@@ -245,7 +245,7 @@ static int tps6586x_regulator_set_slew_rate(struct platform_device *pdev,
reg = TPS6586X_SM1SL;
break;
default:
- dev_warn(&pdev->dev, "Only SM0/SM1 can set slew rate\n");
+ dev_err(&pdev->dev, "Only SM0/SM1 can set slew rate\n");
return -EINVAL;
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] regulator: tps6586x: Use dev_err rather than dev_warn for error message
2013-02-20 2:23 [PATCH] regulator: tps6586x: Use dev_err rather than dev_warn for error message Axel Lin
@ 2013-02-20 7:13 ` Stephen Warren
2013-03-01 7:37 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Stephen Warren @ 2013-02-20 7:13 UTC (permalink / raw)
To: Axel Lin
Cc: Mark Brown, Mike Rapoport, Laxman Dewangan, Liam Girdwood,
linux-kernel
On 02/19/2013 07:23 PM, Axel Lin wrote:
> tps6586x_regulator_set_slew_rate() returns -EINVAL when having slew rate
> settings for other than SM0/1, thus use dev_err rather than dev_warn.
Reviewed-by: Stephen Warren <swarren@nvidia.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] regulator: tps6586x: Use dev_err rather than dev_warn for error message
2013-02-20 2:23 [PATCH] regulator: tps6586x: Use dev_err rather than dev_warn for error message Axel Lin
2013-02-20 7:13 ` Stephen Warren
@ 2013-03-01 7:37 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2013-03-01 7:37 UTC (permalink / raw)
To: Axel Lin
Cc: Stephen Warren, Mike Rapoport, Laxman Dewangan, Liam Girdwood,
linux-kernel
[-- Attachment #1: Type: text/plain, Size: 223 bytes --]
On Wed, Feb 20, 2013 at 10:23:46AM +0800, Axel Lin wrote:
> tps6586x_regulator_set_slew_rate() returns -EINVAL when having slew rate
> settings for other than SM0/1, thus use dev_err rather than dev_warn.
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-03-01 7:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-02-20 2:23 [PATCH] regulator: tps6586x: Use dev_err rather than dev_warn for error message Axel Lin
2013-02-20 7:13 ` Stephen Warren
2013-03-01 7:37 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox