Re: [PATCH v2 2/2] mfd: palmas add variant and OTP detection

Ian Lartey
2013-03-01T23:43:11Z

On 26/02/13 13:53, Laxman Dewangan wrote:
> On Saturday 23 February 2013 10:05 PM, Ian Lartey wrote:
>> From: Graeme Gregory <gg@slimlogic.co.uk>
>>
>> Read the chip varient and the OTP information from the chip and display
>> this on probe to aid in debugging of issues.
>>
>> Older palmas chips do not have the USB_ID programmed and will therefore
>> return 0x0000 for this field.
>
>> +
>> /* Change IRQ into clear on read mode for efficiency */
>> slave = PALMAS_BASE_TO_SLAVE(PALMAS_INTERRUPT_BASE);
>> - addr = PALMAS_BASE_TO_REG(PALMAS_INTERRUPT_BASE, PALMAS_INT_CTRL);
>> reg = PALMAS_INT_CTRL_INT_CLEAR;
>> - regmap_write(palmas->regmap[slave], addr, reg);
>> + ret = palmas_write(palmas, PALMAS_INTERRUPT_BASE,
>> PALMAS_INT_CTRL, reg);
>
> I think this is unrelated change and can be on another patch.

This is the change which you requested earlier "Can you please use the
api palmas_* for reading register which I added recently."

>
>>
>> - slave = PALMAS_BASE_TO_SLAVE(PALMAS_PU_PD_OD_BASE);
>> - addr = PALMAS_BASE_TO_REG(PALMAS_PU_PD_OD_BASE,
>> - PALMAS_PRIMARY_SECONDARY_PAD1);
>> -
>> if (pdata->mux_from_pdata) {
>> reg = pdata->pad1;
>> - ret = regmap_write(palmas->regmap[slave], addr, reg);
>> + ret = palmas_write(palmas, PALMAS_PU_PD_OD_BASE,
>> + PALMAS_PRIMARY_SECONDARY_PAD1, reg);
>
> Same, in another patch and elsewhere which was part of cleanups.

ditto.

>
>
> otherwise it looks good.
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/