From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Thiago Farina <tfransosi@gmail.com>
Cc: linux-kernel@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH 2/2] regulators: max8998.c: use dev_err() instead of printk()
Date: Fri, 1 Mar 2013 15:54:30 +0800 [thread overview]
Message-ID: <20130301075426.GM25302@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1361591486-12663-1-git-send-email-tfarina@chromium.org>
[-- Attachment #1: Type: text/plain, Size: 858 bytes --]
On Sat, Feb 23, 2013 at 12:51:26AM -0300, Thiago Farina wrote:
> Fixes the following checkpatch warning:
>
> WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ...
This doesn't apply against current mainline, and...
> @@ -666,7 +666,7 @@ static int max8998_pmic_probe(struct platform_device *pdev)
> /* Check if SET1 is not equal to 0 */
> if (!pdata->buck1_set1) {
> dev_err(&pdev->dev,
> - "MAX8998 SET1 GPIO defined as 0 !\n");
> + "MAX8998 SET1 GPIO defined as 0 !\n");
> WARN_ON(!pdata->buck1_set1);
> ret = -EIO;
> goto err_out;
...this (which is one of the failing hunks) is an indentation change
which bears no relation to the changelog.
I've applied the final hunk which looks good but please be more careful
in future.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2013-03-01 7:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-23 3:51 [PATCH 2/2] regulators: max8998.c: use dev_err() instead of printk() Thiago Farina
2013-03-01 7:54 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130301075426.GM25302@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tfransosi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox