* [PATCH 2/2] regulators: max8998.c: use dev_err() instead of printk()
@ 2013-02-23 3:51 Thiago Farina
2013-03-01 7:54 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Thiago Farina @ 2013-02-23 3:51 UTC (permalink / raw)
To: linux-kernel; +Cc: Mark Brown, Liam Girdwood
Fixes the following checkpatch warning:
WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ...
Signed-off-by: Thiago Farina <tfarina@chromium.org>
---
drivers/regulator/max8998.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/regulator/max8998.c b/drivers/regulator/max8998.c
index faeb7e8..a57a1b1 100644
--- a/drivers/regulator/max8998.c
+++ b/drivers/regulator/max8998.c
@@ -666,7 +666,7 @@ static int max8998_pmic_probe(struct platform_device *pdev)
/* Check if SET1 is not equal to 0 */
if (!pdata->buck1_set1) {
dev_err(&pdev->dev,
- "MAX8998 SET1 GPIO defined as 0 !\n");
+ "MAX8998 SET1 GPIO defined as 0 !\n");
WARN_ON(!pdata->buck1_set1);
ret = -EIO;
goto err_out;
@@ -674,7 +674,7 @@ static int max8998_pmic_probe(struct platform_device *pdev)
/* Check if SET2 is not equal to 0 */
if (!pdata->buck1_set2) {
dev_err(&pdev->dev,
- "MAX8998 SET2 GPIO defined as 0 !\n");
+ "MAX8998 SET2 GPIO defined as 0 !\n");
WARN_ON(!pdata->buck1_set2);
ret = -EIO;
goto err_out;
@@ -740,7 +740,8 @@ static int max8998_pmic_probe(struct platform_device *pdev)
if (gpio_is_valid(pdata->buck2_set3)) {
/* Check if SET3 is not equal to 0 */
if (!pdata->buck2_set3) {
- printk(KERN_ERR "MAX8998 SET3 GPIO defined as 0 !\n");
+ dev_err(&pdev->dev,
+ "MAX8998 SET3 GPIO defined as 0 !\n");
WARN_ON(!pdata->buck2_set3);
ret = -EIO;
goto err_out;
--
1.8.1.151.g32238ae
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH 2/2] regulators: max8998.c: use dev_err() instead of printk()
2013-02-23 3:51 [PATCH 2/2] regulators: max8998.c: use dev_err() instead of printk() Thiago Farina
@ 2013-03-01 7:54 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2013-03-01 7:54 UTC (permalink / raw)
To: Thiago Farina; +Cc: linux-kernel, Liam Girdwood
[-- Attachment #1: Type: text/plain, Size: 858 bytes --]
On Sat, Feb 23, 2013 at 12:51:26AM -0300, Thiago Farina wrote:
> Fixes the following checkpatch warning:
>
> WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ...
This doesn't apply against current mainline, and...
> @@ -666,7 +666,7 @@ static int max8998_pmic_probe(struct platform_device *pdev)
> /* Check if SET1 is not equal to 0 */
> if (!pdata->buck1_set1) {
> dev_err(&pdev->dev,
> - "MAX8998 SET1 GPIO defined as 0 !\n");
> + "MAX8998 SET1 GPIO defined as 0 !\n");
> WARN_ON(!pdata->buck1_set1);
> ret = -EIO;
> goto err_out;
...this (which is one of the failing hunks) is an indentation change
which bears no relation to the changelog.
I've applied the final hunk which looks good but please be more careful
in future.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-03-01 7:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-02-23 3:51 [PATCH 2/2] regulators: max8998.c: use dev_err() instead of printk() Thiago Farina
2013-03-01 7:54 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox