Re: [PATCH 5/9] blockconsole: use CON_ALLDATA

Jörn Engel
2013-03-01T17:55:18Z

On Fri, 1 March 2013 18:52:20 +0100, Borislav Petkov wrote:
> On Fri, Mar 01, 2013 at 11:20:29AM -0500, Jörn Engel wrote:
> > If you and/or other people are strongly opposed to the CON_ALLDATA
> > patches, I can either keep them private (we will never drop them from
> > our kernel) or add a config option.
>
> We'll do that when someone comes up with a really persuasive reason why
> blockconsole shouldn't log *all* messages. And, whatever we do, I don't
> want to configure/set anything so that blockconsole logs everything - it
> should be the default.

For blockconsole I agree. Netconsole is the interesting one, because
CON_ALLDATA could be considered a regression for it.

Jörn

--
The key to performance is elegance, not battalions of special cases.
-- Jon Bentley and Doug McIlroy