* [PATCH -next] spi: fix return value check in ce4100_spi_probe()
@ 2013-02-22 2:52 Wei Yongjun
2013-02-22 9:33 ` Mika Westerberg
2013-03-02 3:58 ` Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: Wei Yongjun @ 2013-02-22 2:52 UTC (permalink / raw)
To: eric.y.miao, linux, haojian.zhuang, grant.likely, broonie
Cc: yongjun_wei, linux-arm-kernel, spi-devel-general, linux-kernel
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
In case of error, the function platform_device_register_full()
returns ERR_PTR() and never returns NULL. The NULL test in the
return value check should be replaced with IS_ERR().
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
drivers/spi/spi-pxa2xx-pci.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/spi/spi-pxa2xx-pci.c b/drivers/spi/spi-pxa2xx-pci.c
index 364964d..0a11dcfc 100644
--- a/drivers/spi/spi-pxa2xx-pci.c
+++ b/drivers/spi/spi-pxa2xx-pci.c
@@ -47,8 +47,8 @@ static int ce4100_spi_probe(struct pci_dev *dev,
pi.size_data = sizeof(spi_pdata);
pdev = platform_device_register_full(&pi);
- if (!pdev)
- return -ENOMEM;
+ if (IS_ERR(pdev))
+ return PTR_ERR(pdev);
pci_set_drvdata(dev, pdev);
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] spi: fix return value check in ce4100_spi_probe()
2013-02-22 2:52 [PATCH -next] spi: fix return value check in ce4100_spi_probe() Wei Yongjun
@ 2013-02-22 9:33 ` Mika Westerberg
2013-03-02 3:58 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mika Westerberg @ 2013-02-22 9:33 UTC (permalink / raw)
To: Wei Yongjun
Cc: eric.y.miao, linux, haojian.zhuang, grant.likely, broonie,
yongjun_wei, linux-arm-kernel, spi-devel-general, linux-kernel
On Fri, Feb 22, 2013 at 10:52:35AM +0800, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> In case of error, the function platform_device_register_full()
> returns ERR_PTR() and never returns NULL. The NULL test in the
> return value check should be replaced with IS_ERR().
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Nice catch!
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] spi: fix return value check in ce4100_spi_probe()
2013-02-22 2:52 [PATCH -next] spi: fix return value check in ce4100_spi_probe() Wei Yongjun
2013-02-22 9:33 ` Mika Westerberg
@ 2013-03-02 3:58 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2013-03-02 3:58 UTC (permalink / raw)
To: Wei Yongjun
Cc: eric.y.miao, linux, haojian.zhuang, grant.likely, yongjun_wei,
linux-arm-kernel, spi-devel-general, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 327 bytes --]
On Fri, Feb 22, 2013 at 10:52:35AM +0800, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> In case of error, the function platform_device_register_full()
> returns ERR_PTR() and never returns NULL. The NULL test in the
> return value check should be replaced with IS_ERR().
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-03-02 3:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-02-22 2:52 [PATCH -next] spi: fix return value check in ce4100_spi_probe() Wei Yongjun
2013-02-22 9:33 ` Mika Westerberg
2013-03-02 3:58 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox