From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753520Ab3CCMIr (ORCPT ); Sun, 3 Mar 2013 07:08:47 -0500 Received: from mail-da0-f43.google.com ([209.85.210.43]:50768 "EHLO mail-da0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753244Ab3CCMHv (ORCPT ); Sun, 3 Mar 2013 07:07:51 -0500 From: Grant Likely Subject: Re: [PATCH v3] gpio: Add device driver for GRGPIO cores and support custom accessors with gpio-generic To: Linus Walleij , Andreas Larsson Cc: Rob Herring , Anton Vorontsov , linux-kernel@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, software@gaisler.com In-Reply-To: References: <1360653873-25368-1-git-send-email-andreas@gaisler.com> Date: Sat, 02 Mar 2013 20:13:02 +0000 Message-Id: <20130302201302.E16FE3E219B@localhost> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 1 Mar 2013 01:24:01 +0100, Linus Walleij wrote: > On Tue, Feb 12, 2013 at 8:24 AM, Andreas Larsson wrote: > > > This driver supports GRGPIO gpio cores available in the GRLIB VHDL IP > > core library from Aeroflex Gaisler. > > > > This also adds support to gpio-generic for using custom accessor > > functions. The grgpio driver uses this to use ioread32be and iowrite32be > > for big endian register accesses. > > > > Signed-off-by: Andreas Larsson > > Can you split this in two patches: one that adds the custom accessors > and one that adds the driver? Yes please, and as commented on in the other thread you can go ahead and add the BE accessors to gpio-generic.c. I would like to optimize things in gpiolib to make a lot of gpio-generic.c unnecessary, but that is only an idea at this point. g.