From: Grant Likely <grant.likely@secretlab.ca>
To: leroy christophe <christophe.leroy@c-s.fr>,
Linus Walleij <linus.walleij@linaro.org>
Cc: linux-kernel@vger.kernel.org, Patrick Vasseur <patrick.vasseur@c-s.fr>
Subject: Re: [PATCH] Adds support for Open Firmware in MAX730x GPIO Driver
Date: Sat, 02 Mar 2013 21:16:56 +0000 [thread overview]
Message-ID: <20130302211656.879443E21F5@localhost> (raw)
In-Reply-To: <51304ABD.9020706@c-s.fr>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 1393 bytes --]
On Fri, 01 Mar 2013 07:29:17 +0100, leroy christophe <christophe.leroy@c-s.fr> wrote:
>
> Le 01/03/2013 01:43, Linus Walleij a écrit :
> > On Fri, Feb 22, 2013 at 10:26 AM, Christophe Leroy
> > <christophe.leroy@c-s.fr> wrote:
> >
> >> This patch allows the use of the MAX730x Driver on systems using
> >> the Open Firmware platform format
> >>
> >> Signed-off-by: Patrick Vasseur <patrick.vasseur@c-s.fr>
> >> Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
> > (...)
> >> /* bits_per_word cannot be configured in platform data */
> >> - spi->bits_per_word = 16;
> >> + if (spi->dev.platform_data)
> >> + spi->bits_per_word = 16;
> > What about just fixing so you *can* specify that instead?
> > The comment looks more like a FIXME to me.
> Euh, ok, why not. But here the purpose of my patch is to allow using
> this driver with of_platform in addition to platform.
> This FIXME is not mine, it was already existing in that driver.
> As of_platform can configure bits per word, the only thing I did is to
> add a test in order to not apply this FIXME on the of_platform case.
>
> Do you think my patch is not acceptable like this ?
I would like to know /why/ this specific hunk is necessary. I cannot
tell from the context. That's the sort of thing that is very helpful to
have in the commit description. Otherwise the patch looks fine.
g.
next prev parent reply other threads:[~2013-03-03 9:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-22 9:26 [PATCH] Adds support for Open Firmware in MAX730x GPIO Driver Christophe Leroy
2013-03-01 0:43 ` Linus Walleij
2013-03-01 6:29 ` leroy christophe
2013-03-01 9:23 ` Linus Walleij
2013-03-02 21:16 ` Grant Likely [this message]
2013-03-05 15:00 ` leroy christophe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130302211656.879443E21F5@localhost \
--to=grant.likely@secretlab.ca \
--cc=christophe.leroy@c-s.fr \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patrick.vasseur@c-s.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox