public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel@ffwll.ch>
To: Syam Sidhardhan <syamsidhardh@gmail.com>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	airlied@linux.ie, daniel.vetter@ffwll.ch,
	Paulo Zanoni <przanoni@gmail.com>
Subject: Re: [PATCH] drm/i915: Fix missing variable initilization
Date: Sun, 3 Mar 2013 18:20:26 +0100	[thread overview]
Message-ID: <20130303172026.GG9021@phenom.ffwll.local> (raw)
In-Reply-To: <1361745338-28522-1-git-send-email-s.syam@samsung.com>

On Mon, Feb 25, 2013 at 04:05:38AM +0530, Syam Sidhardhan wrote:
> Need to initialize the variable wait to false.
> 
> Signed-off-by: Syam Sidhardhan <s.syam@samsung.com>

Looks sane, thanks for the patch. Cc'ing Paulo in case I've missed
something.
-Daniel

> ---
>  drivers/gpu/drm/i915/intel_ddi.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
> index fc95ef0..5d0a687 100644
> --- a/drivers/gpu/drm/i915/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/intel_ddi.c
> @@ -1391,8 +1391,8 @@ void intel_ddi_prepare_link_retrain(struct drm_encoder *encoder)
>  	struct intel_dp *intel_dp = &intel_dig_port->dp;
>  	struct drm_i915_private *dev_priv = encoder->dev->dev_private;
>  	enum port port = intel_dig_port->port;
> -	bool wait;
>  	uint32_t val;
> +	bool wait = false;
>  
>  	if (I915_READ(DP_TP_CTL(port)) & DP_TP_CTL_ENABLE) {
>  		val = I915_READ(DDI_BUF_CTL(port));
> -- 
> 1.7.9.5
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

  reply	other threads:[~2013-03-03 17:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-24 22:35 [PATCH] drm/i915: Fix missing variable initilization Syam Sidhardhan
2013-03-03 17:20 ` Daniel Vetter [this message]
2013-03-08 14:39   ` Damien Lespiau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130303172026.GG9021@phenom.ffwll.local \
    --to=daniel@ffwll.ch \
    --cc=airlied@linux.ie \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=przanoni@gmail.com \
    --cc=syamsidhardh@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox