From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Ley Foon Tan <lftan@altera.com>, Rob Landley <rob@landley.net>,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH 1/1] drivers/misc: Add Altera System ID driver
Date: Mon, 4 Mar 2013 11:44:30 +0800 [thread overview]
Message-ID: <20130304034430.GA1274@kroah.com> (raw)
In-Reply-To: <201303040332.20076.arnd@arndb.de>
On Mon, Mar 04, 2013 at 03:32:19AM +0000, Arnd Bergmann wrote:
> On Monday 04 March 2013, Ley Foon Tan wrote:
> > This patch is to add Altera System ID driver.
> > User can obtain the system ID and timestamp of the system by
> > reading the sysfs entry.
> >
> > Usage:
> > cat /sys/bus/platform/devices/[addr].sysid/sysid/id
> > cat /sys/bus/platform/devices/[addr].sysid/sysid/timestamp
> >
> > Signed-off-by: Ley Foon Tan <lftan@altera.com>
>
> All sysfs files need documentation in Documentation/ABI/.
>
> This driver looks like it should instead be using the infrastructure we
> have for identifying an SoC in drivers/base/soc.c, which is currently
> only used by the ARM u8500 platform but was introduced as a generic
> interface for this a while ago.
I agree, this shouldn't be a one-off sysfs file.
greg k-h
next prev parent reply other threads:[~2013-03-04 3:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-04 3:11 [PATCH 1/1] drivers/misc: Add Altera System ID driver Ley Foon Tan
2013-03-04 3:32 ` Arnd Bergmann
2013-03-04 3:44 ` Greg Kroah-Hartman [this message]
2013-03-04 9:41 ` Ley Foon Tan
2013-03-04 12:55 ` Arnd Bergmann
2013-03-05 11:12 ` Ley Foon Tan
2013-03-05 21:59 ` Arnd Bergmann
2013-03-08 10:41 ` Ley Foon Tan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130304034430.GA1274@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=lftan@altera.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rob@landley.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox