From: Vinod Koul <vinod.koul@intel.com>
To: Tomoya MORINAGA <tomoya.rohm@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pch_dma: Use GFP_ATOMIC because called from interrupt context
Date: Mon, 4 Mar 2013 10:27:39 +0530 [thread overview]
Message-ID: <20130304045739.GE22513@intel.com> (raw)
In-Reply-To: <CANKRQnhp_+mKnezqWZ2OZxecpac-N0EpmKuV8p285LC3jSEw2w@mail.gmail.com>
> On Tue, Feb 12, 2013 at 11:25 AM, Tomoya MORINAGA <tomoya.rohm@gmail.com> wrote:
> > pdc_desc_get() is called from pd_prep_slave_sg, and the function is
> > called from interrupt context(e.g. Uart driver "pch_uart.c").
> > In fact, I saw kernel error message.
> > So, GFP_ATOMIC must be used not GFP_NOIO.
> >
> > Signed-off-by: Tomoya MORINAGA <tomoya.rohm@gmail.com>
Applied, thanks
> > ---
> > drivers/dma/pch_dma.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/dma/pch_dma.c b/drivers/dma/pch_dma.c
> > index 987ab5c..d5cbd44 100644
> > --- a/drivers/dma/pch_dma.c
> > +++ b/drivers/dma/pch_dma.c
> > @@ -476,7 +476,7 @@ static struct pch_dma_desc *pdc_desc_get(struct pch_dma_chan *pd_chan)
> > dev_dbg(chan2dev(&pd_chan->chan), "scanned %d descriptors\n", i);
> >
> > if (!ret) {
> > - ret = pdc_alloc_desc(&pd_chan->chan, GFP_NOIO);
> > + ret = pdc_alloc_desc(&pd_chan->chan, GFP_ATOMIC);
> > if (ret) {
> > spin_lock(&pd_chan->lock);
> > pd_chan->descs_allocated++;
> > --
> > 1.7.4.4
>
> --
> ROHM Co., Ltd.
> tomoya
prev parent reply other threads:[~2013-03-04 4:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-12 2:25 [PATCH] pch_dma: Use GFP_ATOMIC because called from interrupt context Tomoya MORINAGA
2013-02-20 2:26 ` Tomoya MORINAGA
2013-02-20 5:57 ` Vinod Koul
2013-03-04 4:57 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130304045739.GE22513@intel.com \
--to=vinod.koul@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tomoya.rohm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox