From: Thierry Reding <thierry.reding@avionic-design.de>
To: Sachin Kamat <sachin.kamat@linaro.org>
Cc: linux-kernel@vger.kernel.org, linux@prisktech.co.nz,
grant.likely@secretlab.ca, linus.walleij@linaro.org
Subject: Re: [PATCH 1/1] gpio/vt8500: Convert to devm_ioremap_resource()
Date: Mon, 4 Mar 2013 11:24:46 +0100 [thread overview]
Message-ID: <20130304102446.GB15580@avionic-0098.mockup.avionic-design.de> (raw)
In-Reply-To: <1362388179-26841-1-git-send-email-sachin.kamat@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 579 bytes --]
On Mon, Mar 04, 2013 at 02:39:39PM +0530, Sachin Kamat wrote:
> Use the newly introduced devm_ioremap_resource() instead of
> devm_request_and_ioremap() which provides more consistent error handling.
>
> devm_ioremap_resource() provides its own error messages; so all explicit
> error messages can be removed from the failure code paths.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
> drivers/gpio/gpio-vt8500.c | 8 +++-----
> 1 files changed, 3 insertions(+), 5 deletions(-)
Reviewed-by: Thierry Reding <thierry.reding@avionic-design.de>
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-03-04 10:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-04 9:09 [PATCH 1/1] gpio/vt8500: Convert to devm_ioremap_resource() Sachin Kamat
2013-03-04 10:24 ` Thierry Reding [this message]
2013-03-04 17:08 ` Tony Prisk
2013-03-14 6:45 ` Sachin Kamat
2013-03-27 8:32 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130304102446.GB15580@avionic-0098.mockup.avionic-design.de \
--to=thierry.reding@avionic-design.de \
--cc=grant.likely@secretlab.ca \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@prisktech.co.nz \
--cc=sachin.kamat@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox