[RFC PATCH v2 4/4] timekeeping: utilize the suspend-nonstop clocksource to count suspended time

Feng Tang
2013-03-05T02:28:41Z

There are some new processors whose TSC clocksource won't stop during
suspend. Currently, after system resumes, kernel will use persistent
clock or RTC to compensate the sleep time, but for those new types of
clocksources, we could skip the special compensation from external
sources, and just use current clocksource for time recounting.

This can solve some time drift bugs caused by some not-so-accurate or
error-prone RTC devices.

The current way to count suspened time is first try to use the persistent
clock, and then try the rtc if persistent clock can't be used. This
patch will change the trying order to:
suspend-nonstop clocksource -> persistent clock -> rtc

Signed-off-by: Feng Tang <feng.tang@intel.com>
---
kernel/time/timekeeping.c | 57 ++++++++++++++++++++++++++++++++++++++------
1 files changed, 49 insertions(+), 8 deletions(-)

diff --git a/kernel/time/timekeeping.c b/kernel/time/timekeeping.c
index 9a0bc98..15cc086 100644
--- a/kernel/time/timekeeping.c
+++ b/kernel/time/timekeeping.c
@@ -788,22 +788,63 @@ void timekeeping_inject_sleeptime(struct timespec *delta)
static void timekeeping_resume(void)
{
struct timekeeper *tk = &timekeeper;
+ struct clocksource *clock = tk->clock;
unsigned long flags;
- struct timespec ts;
+ struct timespec ts_new, ts_delta;
+ cycle_t cycle_now, cycle_delta;
+ s64 nsec;

- read_persistent_clock(&ts);
+ ts_delta.tv_sec = 0;
+ read_persistent_clock(&ts_new);

clockevents_resume();
clocksource_resume();

write_seqlock_irqsave(&tk->lock, flags);

- if (timespec_compare(&ts, &timekeeping_suspend_time) > 0) {
- ts = timespec_sub(ts, timekeeping_suspend_time);
- __timekeeping_inject_sleeptime(tk, &ts);
- }
- /* re-base the last cycle value */
- tk->clock->cycle_last = tk->clock->read(tk->clock);
+ /*
+ * After system resumes, we need to calculate the suspended time and
+ * compensate it for the OS time. There are 3 sources that could be
+ * used: Nonstop clocksource during suspend, persistent clock and rtc
+ * device.
+ *
+ * One specific platform may have 1 or 2 or all of them, and the
+ * preference will be:
+ * suspend-nonstop clocksource > persistent clock > rtc
+ * The less preferred source will only be tried if there is no better
+ * usable source. The rtc part is handled separately in rtc core code.
+ */
+ cycle_now = clock->read(clock);
+ if ((clock->flags & CLOCK_SOURCE_SUSPEND_NOTSTOP) &&
+ cycle_now > clock->cycle_last) {
+
+ u64 max_cycles;
+ u32 mult = clock->mult;
+ u32 shift = clock->shift;
+
+ cycle_delta = (cycle_now - clock->cycle_last) & clock->mask;
+ /*
+ * The system suspended time and the delta cycles may be very
+ * long, so we can't call clocksource_cyc2ns() directly with
+ * clocksource's default mult and shift to avoid overflow.
+ */
+ max_cycles = 1ULL << (63 - (ilog2(mult) + 1));
+ while (cycle_delta > max_cycles) {
+ max_cycles <<= 1;
+ mult >>= 1;
+ shift--;
+ }
+
+ nsec = clocksource_cyc2ns(cycle_delta, mult, shift);
+ ts_delta = ns_to_timespec(nsec);
+ } else if (timespec_compare(&ts_new, &timekeeping_suspend_time) > 0)
+ ts_delta = timespec_sub(ts_new, timekeeping_suspend_time);
+
+ if (ts_delta.tv_sec >= 1)
+ __timekeeping_inject_sleeptime(tk, &ts_delta);
+
+ /* Re-base the last cycle value */
+ clock->cycle_last = clock->read(clock);
tk->ntp_error = 0;
timekeeping_suspended = 0;
timekeeping_update(tk, false);
--
1.7.0.4