From: Greg KH <gregkh@linuxfoundation.org>
To: Serban Constantinescu <serban.constantinescu@arm.com>
Cc: linux-kernel@vger.kernel.org, kernel-team@android.com,
arve@android.com, john.stultz@linaro.org, Dave.Butcher@arm.com
Subject: Re: [PATCH] staging: android: ashmem: Add support for 32bit ashmem calls in a 64bit kernel
Date: Tue, 5 Mar 2013 16:37:07 +0800 [thread overview]
Message-ID: <20130305083707.GA7513@kroah.com> (raw)
In-Reply-To: <1361817876-24747-2-git-send-email-serban.constantinescu@arm.com>
On Mon, Feb 25, 2013 at 06:44:36PM +0000, Serban Constantinescu wrote:
> Android's shared memory subsystem, Ashmem, does not support calls from a
> 32bit userspace in a 64 bit kernel. This patch adds support for syscalls
> coming from a 32bit userspace in a 64bit kernel.
>
> The patch has been successfully tested on ARMv8 AEM(64bit
> platform model) and Versatile Express A9(32bit platform).
>
> Signed-off-by: Serban Constantinescu <serban.constantinescu@arm.com>
> Acked-by: Arve Hjønnevåg <arve@android.com>
> Acked-by: John Stultz <john.stultz@linaro.org>
This patch breaks the build on my machine:
drivers/staging/android/ashmem.c: In function ‘compat_ashmem_ioctl’:
drivers/staging/android/ashmem.c:711:7: error: ‘compat_size_t’ undeclared (first use in this function)
drivers/staging/android/ashmem.c:711:7: note: each undeclared identifier is reported only once for each function it appears in
so of course, I can't take it :(
greg k-h
next prev parent reply other threads:[~2013-03-05 8:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <staging: android: ashmem: add 32bit compat support>
2013-02-25 18:44 ` [PATCH] staging: android: ashmem: add 32bit compat support Serban Constantinescu
2013-02-25 18:44 ` [PATCH] staging: android: ashmem: Add support for 32bit ashmem calls in a 64bit kernel Serban Constantinescu
2013-02-25 18:55 ` John Stultz
2013-02-25 22:53 ` Arve Hjønnevåg
2013-03-05 8:37 ` Greg KH [this message]
2013-03-05 10:18 ` Serban Constantinescu
2013-03-05 10:27 ` Greg KH
2013-03-05 10:38 ` Serban Constantinescu
2013-03-05 10:47 ` Greg KH
2013-03-05 10:25 ` Serban Constantinescu
2013-02-25 18:57 ` [PATCH] staging: android: ashmem: add 32bit compat support Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130305083707.GA7513@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Dave.Butcher@arm.com \
--cc=arve@android.com \
--cc=john.stultz@linaro.org \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=serban.constantinescu@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox