From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756759Ab3CEODB (ORCPT ); Tue, 5 Mar 2013 09:03:01 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:17550 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756185Ab3CEOC7 (ORCPT ); Tue, 5 Mar 2013 09:02:59 -0500 Date: Tue, 5 Mar 2013 09:02:54 -0500 From: Konrad Rzeszutek Wilk To: Greg KH Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, dan.magenheimer@oracle.com Subject: Re: [PATCH 11/11] zcache/zbud: Add incremental accessory counters Message-ID: <20130305140254.GD2589@phenom.dumpdata.com> References: <1362421101-15896-1-git-send-email-konrad.wilk@oracle.com> <1362421101-15896-12-git-send-email-konrad.wilk@oracle.com> <20130305084453.GA861@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130305084453.GA861@kroah.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: acsinet21.oracle.com [141.146.126.237] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 05, 2013 at 04:44:53PM +0800, Greg KH wrote: > On Mon, Mar 04, 2013 at 01:18:21PM -0500, Konrad Rzeszutek Wilk wrote: > > that are going to be used for debug fs entries. > > what debugfs entries? > > > > > Acked-by: Dan Magenheimer > > Signed-off-by: Konrad Rzeszutek Wilk > > --- > > drivers/staging/zcache/zbud.c | 58 +++++++++++++++++++++++++++++-------------- > > 1 file changed, 39 insertions(+), 19 deletions(-) > > > > diff --git a/drivers/staging/zcache/zbud.c b/drivers/staging/zcache/zbud.c > > index fdff5c6..0feb856 100644 > > --- a/drivers/staging/zcache/zbud.c > > +++ b/drivers/staging/zcache/zbud.c > > @@ -301,6 +301,26 @@ static ssize_t zbud_eph_unbuddied_count; > > static ssize_t zbud_pers_unbuddied_count; > > static ssize_t zbud_eph_zombie_count; > > static ssize_t zbud_pers_zombie_count; > > +static inline void inc_zbud_eph_pageframes(void) { zbud_eph_pageframes++; }; > > +static inline void inc_zbud_pers_pageframes(void) { zbud_pers_pageframes++; }; > > +static inline void inc_zbud_eph_zpages(void) { zbud_eph_zpages++; }; > > > > That's just insane, why are you doing this? To move them out to their own file, such as debug.h. And if the user does not want the DebugFS entries for zbud_eph_p* then these: inc_zbud_eph_pageframes(void) .. will now be defined as: static inline void inc_zbud_...(void) { }; and essentially are NOPs. > > As you aren't using this yet, I'm not going to apply this patch, sorry. OK. Will finish off that part of the cleanup and repost it for the zbud. > > greg k-h