From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757223Ab3CERoG (ORCPT ); Tue, 5 Mar 2013 12:44:06 -0500 Received: from mx1.redhat.com ([209.132.183.28]:5042 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753298Ab3CERoE (ORCPT ); Tue, 5 Mar 2013 12:44:04 -0500 Date: Tue, 5 Mar 2013 18:42:04 +0100 From: Oleg Nesterov To: Michel Lespinasse Cc: linux-kernel@vger.kernel.org, Peter Zijlstra , Ingo Molnar , Lai Jiangshan , "Srivatsa S. Bhat" , paulmck@linux.vnet.ibm.com, Rusty Russell , rostedt@goodmis.org, tglx@linutronix.de, Andrew Morton , Andi Kleen Subject: Re: [PATCH 2/2] lglock: update lockdep annotations to report recursive local locks Message-ID: <20130305174204.GB5012@redhat.com> References: <1362449845-7492-1-git-send-email-walken@google.com> <1362449845-7492-3-git-send-email-walken@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1362449845-7492-3-git-send-email-walken@google.com> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/04, Michel Lespinasse wrote: > > Both issues are easily fixed by indicating to lockdep that lglock's local > locks are not recursive. We shouldn't use the rwlock acquire/release > functions here, as lglock doesn't share the same semantics. Instead > we can base our lockdep annotations on the lock_acquire_shared > (for local lglock) and lock_acquire_exclusive (for global lglock) > helpers. IOW, with this patch lglock looks like rw_semaphore for lockdep... Again, I can't ack this change, but afaics it is fine. Oleg.