From: Greg KH <gregkh@linuxfoundation.org>
To: Tejun Heo <tj@kernel.org>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
bfields@fieldses.org, jackm@dev.mellanox.co.il,
ogerlitz@mellanox.com, roland@purestorage.com,
dan.magenheimer@oracle.com, vjaquez@igalia.com,
rene.sapiens@ti.com, x0095078@ti.com, omar.ramirez@ti.com
Subject: Re: [PATCH 6/7] tidspbridge: convert to idr_alloc()
Date: Wed, 6 Mar 2013 05:37:03 +0800 [thread overview]
Message-ID: <20130305213703.GA10826@kroah.com> (raw)
In-Reply-To: <1362513772-15174-7-git-send-email-tj@kernel.org>
On Tue, Mar 05, 2013 at 12:02:51PM -0800, Tejun Heo wrote:
> idr_get_new*() and friends are about to be deprecated. Convert to the
> new idr_alloc() interface.
>
> There are some peculiarities and possible bugs in the converted
> functions. This patch preserves those.
>
> * drv_insert_node_res_element() returns -ENOMEM on alloc failure,
> -EFAULT if id space is exhausted. -EFAULT is at best misleading.
>
> * drv_proc_insert_strm_res_element() is even weirder. It returns
> -EFAULT if kzalloc() fails, -ENOMEM if idr preloading fails and
> -EPERM if id space is exhausted. What's going on here?
>
> * drv_proc_insert_strm_res_element() doesn't free *pstrm_res after
> failure.
>
> Only compile tested.
>
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Víctor Manuel Jáquez Leal <vjaquez@igalia.com>
> Cc: Rene Sapiens <rene.sapiens@ti.com>
> Cc: Armando Uribe <x0095078@ti.com>
> Cc: Omar Ramirez Luna <omar.ramirez@ti.com>
> ---
> drivers/staging/tidspbridge/rmgr/drv.c | 70 +++++++++++++---------------------
> 1 file changed, 26 insertions(+), 44 deletions(-)
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
next prev parent reply other threads:[~2013-03-05 21:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-05 20:02 [PATCHSET 3.9-rc1] idr: final idr_alloc() conversions and deprecation of old interface Tejun Heo
2013-03-05 20:02 ` [PATCH 1/7] nfsd: remove unused get_new_stid() Tejun Heo
2013-03-05 20:05 ` J. Bruce Fields
2013-03-05 20:02 ` [PATCH 2/7] nfsd: convert to idr_alloc() Tejun Heo
2013-03-05 22:31 ` J. Bruce Fields
2013-03-05 20:02 ` [PATCH 3/7] workqueue: " Tejun Heo
2013-03-05 20:02 ` [PATCH 4/7] mlx4: remove leftover idr_pre_get() call Tejun Heo
2013-03-05 20:02 ` [PATCH 5/7] zcache: convert to idr_alloc() Tejun Heo
2013-03-05 21:37 ` Greg KH
2013-03-05 20:02 ` [PATCH 6/7] tidspbridge: " Tejun Heo
2013-03-05 21:37 ` Greg KH [this message]
2013-03-05 20:02 ` [PATCH 7/7] idr: deprecate idr_pre_get() and idr_get_new[_above]() Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130305213703.GA10826@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=akpm@linux-foundation.org \
--cc=bfields@fieldses.org \
--cc=dan.magenheimer@oracle.com \
--cc=jackm@dev.mellanox.co.il \
--cc=linux-kernel@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=omar.ramirez@ti.com \
--cc=rene.sapiens@ti.com \
--cc=roland@purestorage.com \
--cc=tj@kernel.org \
--cc=vjaquez@igalia.com \
--cc=x0095078@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox