From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Joe Perches <joe@perches.com>
Cc: linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org,
devel@driverdev.osuosl.org, dan.magenheimer@oracle.com
Subject: Re: [PATCH 05/11] zcache: Make the debug code use pr_debug
Date: Tue, 5 Mar 2013 16:54:30 -0500 [thread overview]
Message-ID: <20130305215430.GB18408@phenom.dumpdata.com> (raw)
In-Reply-To: <1362421733.1965.11.camel@joe-AO722>
On Mon, Mar 04, 2013 at 10:28:53AM -0800, Joe Perches wrote:
> On Mon, 2013-03-04 at 13:18 -0500, Konrad Rzeszutek Wilk wrote:
> > as if you are debugging this driver you would be using 'debug'
> > on the command line anyhow - and this would dump the debug
> > data on the proper loglevel.
>
> Please add
> #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> before any #includes and remove all the "zcache: "
> prefixes from the pr_<level> uses.
>
>
> > + pr_debug("zcache: obj_count=%zd\n", zcache_obj_count);
>
> just pr_debug("obj_count=%zd\n", zcache_obj_count);
Sure. Let me spin out another patch for this.
next prev parent reply other threads:[~2013-03-05 21:54 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-04 18:18 [PATCH] Various fixes for zcache for v3.10 Konrad Rzeszutek Wilk
2013-03-04 18:18 ` [PATCH 01/11] zcache: s/int/bool/ on the various options Konrad Rzeszutek Wilk
2013-03-04 18:18 ` [PATCH 02/11] zcache: Provide accessory functions for counter increase Konrad Rzeszutek Wilk
2013-03-04 18:18 ` [PATCH 03/11] zcache: Provide accessory functions for counter decrease Konrad Rzeszutek Wilk
2013-03-04 18:18 ` [PATCH 04/11] zcache: The last of the atomic reads has now an accessory function Konrad Rzeszutek Wilk
2013-03-04 18:18 ` [PATCH 05/11] zcache: Make the debug code use pr_debug Konrad Rzeszutek Wilk
2013-03-04 18:28 ` Joe Perches
2013-03-05 21:54 ` Konrad Rzeszutek Wilk [this message]
2013-03-04 18:18 ` [PATCH 06/11] zcache: Move debugfs code out of zcache-main.c file Konrad Rzeszutek Wilk
2013-03-04 18:18 ` [PATCH 07/11] zcache/debug: Use an array to initialize/use debugfs attributes Konrad Rzeszutek Wilk
2013-03-04 18:18 ` [PATCH 08/11] zcache: Move the last of the debugfs counters out Konrad Rzeszutek Wilk
2013-03-04 18:18 ` [PATCH 09/11] zcache: Module license is defined twice Konrad Rzeszutek Wilk
2013-03-04 18:18 ` [PATCH 10/11] zcache/debug: Coalesce all debug under CONFIG_ZCACHE_DEBUG Konrad Rzeszutek Wilk
2013-03-04 18:18 ` [PATCH 11/11] zcache/zbud: Add incremental accessory counters Konrad Rzeszutek Wilk
2013-03-05 8:44 ` Greg KH
2013-03-05 14:02 ` Konrad Rzeszutek Wilk
-- strict thread matches above, loose matches on Subject: below --
2012-11-14 19:12 [PATCH v2] enable all tmem backends to be built and loaded as modules Konrad Rzeszutek Wilk
2012-11-14 19:12 ` [PATCH 05/11] zcache: Make the debug code use pr_debug Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130305215430.GB18408@phenom.dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=dan.magenheimer@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox