From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Bryan Wu <cooloney@gmail.com>
Cc: Richard Purdie <rpurdie@rpsys.net>,
patches@opensource.wolfsonmicro.com, linux-leds@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] leds: wm8350: Complain if we fail to reenable DCDC
Date: Wed, 6 Mar 2013 12:55:37 +0800 [thread overview]
Message-ID: <20130306045534.GE4896@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <CAK5ve-+FTv1OTfJozs_sy7B0Zd6SzzBOU_1En4AMQCw1RZjprw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 723 bytes --]
On Tue, Mar 05, 2013 at 11:03:52AM -0800, Bryan Wu wrote:
> On Fri, Mar 1, 2013 at 11:40 PM, Mark Brown
> > if (ret != 0) {
> > dev_err(led->cdev.dev, "Failed to disable ISINK: %d\n", ret);
> > - regulator_enable(led->dcdc);
> > + ret = regulator_enable(led->dcdc);
> > + if (ret != 0) {
> looks like we don't need this bracket here.
>
> > + dev_err(led->cdev.dev, "Failed to reenable DCDC: %d\n",
> > + ret);
> > + }
> ditto.
It's not required but since it's inside a small but multi-line block
there's the whole thing about including braces at all levels for
clarity.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-03-06 4:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-02 7:40 [PATCH] leds: wm8350: Complain if we fail to reenable DCDC Mark Brown
2013-03-05 19:03 ` Bryan Wu
2013-03-06 4:55 ` Mark Brown [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-03-06 5:01 Mark Brown
2013-03-06 17:50 ` Bryan Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130306045534.GE4896@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=cooloney@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox