Re: [PATCH] acerhdf: Fix fan activation with new thermal governor

Zhang Rui
2013-02-25T03:06:47Z

On Sun, 2013-02-24 at 13:09 +0100, Borislav Petkov wrote:
> On Sun, Feb 24, 2013 at 12:42:55PM +0100, Peter Feuerer wrote:
> > Hi Boris,
> >
> > thanks for your best wishes in the last mail, I'm feeling little better now.
>
> Nice :)
>
> > Please test my last patch with the 4 trip points ;) - even if you
> > don't really like it, it is working great! - And to be honest, I still
> > prefer this solution!
>
> Right, but 4 trip points for this simple driver is a bit of a overkill,
> don't you think? If we want to be really accurate, we'd only need two,
> think of three temperature intervals here:
>
> 0 - temp <= fanon
> 1 - fanon =< temp < crit
> 2 - temp >= crit
>
> I need to go stare at it a bit more.
>
actually, I still do not understand how the two active trip points
mechanism work.

say,
act1 = 50C, act2=60C

when the temperature goes up to 50C, will the fan be turned on or not?

thanks,
rui