Re: [PATCH] acerhdf: Fix fan activation with new thermal governor

Zhang Rui
2013-03-06T03:47:28Z

On Tue, 2013-03-05 at 22:59 +0100, Andreas Mohr wrote:
> Hi,
>
> On Mon, Mar 04, 2013 at 02:34:10PM +0100, Borislav Petkov wrote:
> > On Mon, Feb 25, 2013 at 01:16:08PM +0100, Borislav Petkov wrote:
> > > Ok, doing a short test here proves successful. I'll run it the next days
> > > too to make sure - it would be nice if people could confirm my test
> > > results, though.
> > >
> > > Tested-by: Borislav Petkov <bp@suse.de>
> >
> > Pjooiiing!
> >
> > Andreas, Peter, can you guys give http://lkml.org/lkml/2012/12/30/47 a run?
>
> I'm now running 3.8 proper with only that patch plus my local
> beautification-only (really shouldn't matter)
> acerhdf updates (now properly split ;),
> and so far fan behaviour seems fine, over various usage conditions.
> Haven't really stressed it mischievously yet, though. Will do more testing.
>
> So this now does not have any of the Schmitt trigger equivalent (?)
> governor changes that were nicely discussed in this activity -
> So what do we want to have committed, and what do we not,

the problem should have been fixed in 3.9-rc1 by
commit b8bb6cb999858043489c1ddef08eed2127559169
Author: Zhang Rui <rui.zhang@intel.com>
Date: Thu Nov 22 15:45:02 2012 +0800

step_wise: Unify the code for both throttle and dethrottle

Signed-off-by: Zhang Rui <rui.zhang@intel.com>

I'll send Alexander' patch for 3.8 stable.

thanks,
rui
> and most importantly, does it all work fatally precisely correctly? ;)
> (remember, this is thermal layer, not particularly a place for sloppiness)
>
> Thanks,
>
> Andreas Mohr