Re: thermal governor: does it actually work??

Alexander Lam
2013-02-18T20:34:13Z

On Feb 18, 2013 7:11 AM, "Zhang, Rui" <rui.zhang@intel.com> wrote:
>
> Sorry I missed that patch.
>
> So the problem happens when the acerhdf thermal zone is registered when the fan has already been spinning, right?

Correct, when the acerhdf driver is switched into kernel controlled
mode and the fan is spinning, it stays spinning until the temperature
goes above the fan-on trip point and then below the fan-off trip
point. then the fan shuts off.

I don't have an opinion on how this is fixed, so do whatever you want
with my patch. Maybe you should drop it entirely if we do end up
applying Peter's fix.

>
>
>
> Thanks,
>
> rui
>
>
>
> From: Alexander Lam [mailto:azl@andrew.cmu.edu]
> Sent: Sunday, February 17, 2013 4:56 AM
> To: Andreas Mohr
> Cc: Zhang, Rui; linux-kernel@vger.kernel.org; R, Durgadoss; peter@piie.net; lenb@kernel.org
> Subject: Re: thermal governor: does it actually work??
> Importance: High
>
>
>
> I wrote a patch to fix this:
>
>
> http://lkml.org/lkml/2012/12/30/47
>
> But nobody picked it up and since then I have been too busy to respin the patch for new -rc kernels.
>
> -Alexander Lam
>
> On Fri, Feb 15, 2013 at 10:49 AM, Andreas Mohr <andi@lisas.de> wrote:
>
> Hi,
>
>
> On Fri, Feb 15, 2013 at 09:47:07AM +0000, Zhang, Rui wrote:
> > Please attach the output of
> > "grep . /sys/class/thermal/thermal_zone*/cdev*/*"?
>
> # grep . /sys/class/thermal/thermal_zone*/cdev*/*
> /sys/class/thermal/thermal_zone0/cdev0/cur_state:1
> /sys/class/thermal/thermal_zone0/cdev0/max_state:1
> grep: /sys/class/thermal/thermal_zone0/cdev0/power: Is a directory
> grep: /sys/class/thermal/thermal_zone0/cdev0/subsystem: Is a directory
> /sys/class/thermal/thermal_zone0/cdev0/type:acerhdf-fan
>
>
> > The question is that if we can also call it "throttle" when reducing the device performance to generate less heat.
>
> I won't continue to elaborate on this separate issue now, given that my time
> currently is very limited ;)
>
>
> Andreas Mohr
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
>

-Alexander Lam