From: Dan Carpenter <dan.carpenter@oracle.com>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Naveen Krishna Chatradhi <ch.naveen@samsung.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-samsung-soc@vger.kernel.org, gregkh@linuxfoundation.org,
naveenkrishna.ch@gmail.com, kbuild@01.org
Subject: Re: [PATCH] iio: adc: exynos5_adc: fix compilation warnings
Date: Wed, 6 Mar 2013 12:26:44 +0300 [thread overview]
Message-ID: <20130306092643.GA9245@mwanda> (raw)
In-Reply-To: <513701FF.3000805@metafoo.de>
On Wed, Mar 06, 2013 at 09:44:47AM +0100, Lars-Peter Clausen wrote:
> On 03/06/2013 05:11 AM, Naveen Krishna Chatradhi wrote:
> > From: Naveen Krishna Ch <ch.naveen@samsung.com>
> >
> > Fixes the compilation warnings and potential NULL pointer
> > dereferencing pointed out by "Dan Carpenter".
> >
>
> I'd say that's a rather un-potential NULL pointer dereferencing, but if it
> makes the static checkers happy, why not. Since the same match table is used to
> match the device, probe won't be called unless there is a match, so
> of_match_node() will never return NULL in this case.
>
Actually the reason Smatch complains is because this was built with
CONFIG_OF=n. Probably it should depend on that in the Kconfig file?
The static checker warnings are a semi automatic thing and we only
send the one email and then mark them as looked at. It's not worth
silencing false positives unless it makes the code easier to
audit.
regards,
dan carpenter
next prev parent reply other threads:[~2013-03-06 9:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-06 4:11 [PATCH] iio: adc: exynos5_adc: fix compilation warnings Naveen Krishna Chatradhi
2013-03-06 8:44 ` Lars-Peter Clausen
2013-03-06 9:26 ` Dan Carpenter [this message]
2013-03-06 13:15 ` Naveen Krishna Ch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130306092643.GA9245@mwanda \
--to=dan.carpenter@oracle.com \
--cc=ch.naveen@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=kbuild@01.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=naveenkrishna.ch@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox