From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754786Ab3CFUEy (ORCPT ); Wed, 6 Mar 2013 15:04:54 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:37215 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752971Ab3CFUEx (ORCPT ); Wed, 6 Mar 2013 15:04:53 -0500 Date: Wed, 6 Mar 2013 15:04:44 -0500 From: Konrad Rzeszutek Wilk To: Greg KH Cc: Stephen Rothwell , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: linux-next: build failure after merge of the final tree (staging tree related) Message-ID: <20130306200444.GA13744@phenom.dumpdata.com> References: <20130306113508.9c868be103b6b140295c548f@canb.auug.org.au> <20130306004341.GA28426@kroah.com> <20130306135654.GA10760@phenom.dumpdata.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130306135654.GA10760@phenom.dumpdata.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: acsinet22.oracle.com [141.146.126.238] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 06, 2013 at 08:56:54AM -0500, Konrad Rzeszutek Wilk wrote: > On Wed, Mar 06, 2013 at 08:43:41AM +0800, Greg KH wrote: > > On Wed, Mar 06, 2013 at 11:35:08AM +1100, Stephen Rothwell wrote: > > > Hi all, > > > > > > After merging the final tree, today's linux-next build (powerpc > > > allyesconfig) failed like this: > > > > > > In file included from drivers/staging/zcache/debug.c:2:0: > > > drivers/staging/zcache/debug.h: In function 'dec_zcache_obj_count': > > > drivers/staging/zcache/debug.h:16:2: error: implicit declaration of function 'BUG_ON' [-Werror=implicit-function-declaration] > > > > > > Caused by commit 95bdaee2140e ("zcache: Move debugfs code out of > > > zcache-main.c file"). > > > > > > I applied this patch for today: > > > > > > From 24b03cf426007c4e94c6bed81560e436afcc136c Mon Sep 17 00:00:00 2001 > > > From: Stephen Rothwell > > > Date: Wed, 6 Mar 2013 11:31:06 +1100 > > > Subject: [PATCH] disable ZCACHE_DEBUG due to build error > > > > > > In file included from drivers/staging/zcache/debug.c:2:0: > > > drivers/staging/zcache/debug.h: In function 'dec_zcache_obj_count': > > > drivers/staging/zcache/debug.h:16:2: error: implicit declaration of function 'BUG_ON' [-Werror=implicit-function-declaration] > > > > > > Signed-off-by: Stephen Rothwell > > > --- > > > drivers/staging/zcache/Kconfig | 1 + > > > 1 file changed, 1 insertion(+) > > > > Ick, sorry about that, I've applied your patch to my tree. > > Wait, there is no BUG_ON on PPC? Or is the definition for it hidden in layers > of #include files? Would this also solve it: I got the cross-compiler up and the patch below does indeed solve the problem. Greg, could you apply the patch below please? > > > diff --git a/drivers/staging/zcache/debug.h b/drivers/staging/zcache/debug.h > index eef67db..494cea02 100644 > --- a/drivers/staging/zcache/debug.h > +++ b/drivers/staging/zcache/debug.h > @@ -1,5 +1,7 @@ > #ifdef CONFIG_ZCACHE_DEBUG > > +#include > + > /* we try to keep these statistics SMP-consistent */ > static ssize_t zcache_obj_count; > static atomic_t zcache_obj_atomic = ATOMIC_INIT(0); > > > ? (going to get my PPC compiler ready shortly to check this out). > So, irrespective of zcache, I also see this: init/built-in.o: In function `.rd_load_image': (.init.text+0x1b24): undefined reference to `.__bswapdi2' arch/powerpc/kernel/built-in.o: In function `.iowa_writeq': io-workarounds.c:(.text+0x2f778): undefined reference to `.__bswapdi2' arch/powerpc/kernel/built-in.o: In function `.iowa_readq': io-workarounds.c:(.text+0x2f848): undefined reference to `.__bswapdi2' arch/powerpc/platforms/built-in.o: In function `.spiderpci_readq': spider-pci.c:(.text+0x2a84c): undefined reference to `.__bswapdi2' arch/powerpc/platforms/built-in.o: In function `.scc_pciex_readq': celleb_scc_pciex.c:(.text+0x2fc4c): undefined reference to `.__bswapdi2' fs/built-in.o:(.text+0x9717c): more undefined references to `.__bswapdi2' follow Is that new? > > > > thanks, > > > > greg k-h